From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A4C8C2C2F for ; Wed, 24 Oct 2018 12:43:33 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 03:43:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="83745351" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga007.jf.intel.com with SMTP; 24 Oct 2018 03:43:30 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Oct 2018 11:43:28 +0100 Date: Wed, 24 Oct 2018 11:43:28 +0100 From: Bruce Richardson To: Hari kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com Message-ID: <20181024104328.GC6128@bricha3-MOBL.ger.corp.intel.com> References: <1539354799-21027-1-git-send-email-hari.kumarx.vemula@intel.com> <1540372032-28642-1-git-send-email-hari.kumarx.vemula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540372032-28642-1-git-send-email-hari.kumarx.vemula@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v4 0/5] create different meson test targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 10:43:34 -0000 On Wed, Oct 24, 2018 at 10:07:07AM +0100, Hari kumar Vemula wrote: > From: Hari Kumar Vemula > > 1/5: remove existing test cases to reorganize further > 2/5: add test-fast suite to meson targets > 3/5: add test-perf suite to meson targets > 4/5: add test-driver suite to meson targets > 5/5: add test-dump suite to meson targets > > -- > v4: Removed test from file prefix > v3: Updated testcase names in file prefix option > v2: Divided fast-test list into two lists > -- > > Hari Kumar Vemula (5): > test: remove existing testcases for categorization > test: add quick run tests under test-fast suite > test: add performance tests under test-perf suite > test: add library dependent tests under test-driver suite > test: add dump test cases under test-dump suite > > test/test/meson.build | 288 ++++++++++++++++++++++++++++++-------------------- > 1 file changed, 174 insertions(+), 114 deletions(-) > The idea looks good to me, I like it. Couple of minor things I've pointed out on specific patches. The other comment I have, is that I think the names would read better with the words switched, and made plural i.e. test-fast ==> fast-tests test-perf ==> perf-tests test-driver ==> driver-tests Not sure about "dump-tests", though, maybe "debug-tests" might be better? The big issue that I see is that I think a lot of our tests are not as reliable as we'd like. However, since that is unrelated to this set, with the renames above and the comments on specific patches fixed: Acked-by: Bruce Richardson PS: the series is not showing up properly in patchwork. Please check your patch threading settings in git.