From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 8EFF654AE for ; Wed, 24 Oct 2018 16:02:17 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id i4-v6so5704654wrr.13 for ; Wed, 24 Oct 2018 07:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5qKywDDOKN8lIQEdDm24qznDntCHI9xCk7viAbof8J8=; b=jwYKSxKt5ahZiEXOcXv2uF7x0jj6dZm14gwy7Fo6uZLjQwK4DhhamHafLkQcHeWc7z IW6vkK2J+xAn9XKkSzQK/3Y6gHWUGKc5EN7yWW851rdYosyrB/MXHnU479NEQ0nRL4U1 hC1yf//++2PXCVnWeEH/AKjws61zCUiXmsv4FzgTG6AdUiKu/604lNX0ld5PlZ7B91oy BuKRlATSqG47IfBh6wLd6SbeEPPmn4GgIr0TMTHgy17lYW+nLVCNMP8QU2BEEDCZFGar 0c/pvM+ie8QuUXUBWmoRuRv3IxxLZxHIZvVgCYw4QKhK0ZXDLiUrKprCTiebLATJW5fc 4bxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5qKywDDOKN8lIQEdDm24qznDntCHI9xCk7viAbof8J8=; b=ZG6Biv+C0Xi5waI0r8JcScafq7vsmtm390NGP5FTlGoBJSmKvYy5ueFN/tC/WRQKWc X1D/YWcLMq3dX9ZEPXq9B47K5BmW+PewoMV8nA4TK3yP52hPby8r1ux37MDSLOd1pEK+ tX3A98oTmL0F1swxujL5R2zEBMKyXFEWPn3FvjOM8FkcBO/Ty9cE2mjPDL4ZRbUDLnF3 F7ueUD/K/rQZ9fKVTLaD7FXNUPO+44DdST00R5ZXg3iKT8gKN+mxysZpKkZiSKfXDIBe z2x0vxXNqpRlD0w3fqLcjuVj1bSAElkou9b3iXQM65vIGQvpIvX/ThsrHZWkhPFEjuyq yJDg== X-Gm-Message-State: AGRZ1gLXhdw56nwd9mgtC/XBJLPIXJHCNC02nCJL5FkPOf+1RicY+/Zz 3YNdN7w26SzwgtickATnzo4NAw== X-Google-Smtp-Source: AJdET5edlmDFykuX9juGtLRQofPfa3INs7rd/tRS3n/6zqfAxGUkWCPQJykF8/JBY/RAWt0cjiaY/w== X-Received: by 2002:adf:f18c:: with SMTP id h12-v6mr2947780wro.86.1540389736814; Wed, 24 Oct 2018 07:02:16 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o13sm4491009wrx.53.2018.10.24.07.02.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 07:02:15 -0700 (PDT) Date: Wed, 24 Oct 2018 16:01:57 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Kevin Laatz Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, shreyansh.jain@nxp.com, thomas@monjalon.net, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com Message-ID: <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com> References: <20181022110014.82153-1-kevin.laatz@intel.com> <20181024132725.5142-1-kevin.laatz@intel.com> <20181024132725.5142-2-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181024132725.5142-2-kevin.laatz@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 14:02:17 -0000 Hi Kevin, On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote: > This commit adds infrastructure to EAL that allows an application to > register it's init function with EAL. This allows libraries to be > initialized at the end of EAL init. > > This infrastructure allows libraries that depend on EAL to be initialized > as part of EAL init, removing circular dependency issues. > > Signed-off-by: Kevin Laatz > Acked-by: Harry van Haaren I think this is good enough, Acked-by: Gaetan Rivet The only remaining issue is rte_option_init(). Sorry I missed your previous message and did not respond in time, I would have opted for leaving a return value to at least be able to stop the init on error. It is possible to force the callback type to return an error value along with a string / hint describing the error. It should not be hard to add it later, so not blocking IMO. -- Gaëtan Rivet 6WIND