From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C25E02C2F; Thu, 25 Oct 2018 07:35:57 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 22:35:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="91071159" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by FMSMGA003.fm.intel.com with ESMTP; 24 Oct 2018 22:35:55 -0700 Date: Thu, 25 Oct 2018 13:35:46 +0800 From: Ye Xiaolong To: Beilei Xing Cc: qi.z.zhang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20181025053546.GA55104@intel.com> References: <1540275271-71330-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540275271-71330-1-git-send-email-beilei.xing@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: update Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 05:35:58 -0000 On 10/23, Beilei Xing wrote: >Tx offload mask is updated in following commit: >commit 1037ed842c37 ("mbuf: fix Tx offload mask"). >Currently, the new added offload flags will be >not supported in PMD and application will fail Shouldn't it be "the new added offlaod flags are not supported in PMD and xxxx"? Thanks, Xiaolong >to call PMD transmit prepare function. >This patch updates PMD Tx offload mask. > >Cc: stable@dpdk.org > >Signed-off-by: Beilei Xing >--- > drivers/net/i40e/i40e_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c >index b2819f7..a827456 100644 >--- a/drivers/net/i40e/i40e_rxtx.c >+++ b/drivers/net/i40e/i40e_rxtx.c >@@ -55,6 +55,10 @@ > PKT_TX_OUTER_IP_CKSUM) > > #define I40E_TX_OFFLOAD_MASK ( \ >+ PKT_TX_OUTER_IPV4 | \ >+ PKT_TX_OUTER_IPV6 | \ >+ PKT_TX_IPV4 | \ >+ PKT_TX_IPV6 | \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > PKT_TX_OUTER_IP_CKSUM | \ >-- >2.5.5 >