From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3395B2E81 for ; Thu, 25 Oct 2018 08:08:56 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 23:08:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="102309987" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2018 23:08:55 -0700 Date: Thu, 25 Oct 2018 14:08:45 +0800 From: Ye Xiaolong To: Zhirun Yan Cc: dev@dpdk.org, qi.z.zhang@intel.com, beilei.xing@intel.com Message-ID: <20181025060845.GB55104@intel.com> References: <20181025134216.37416-1-zhirun.yan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025134216.37416-1-zhirun.yan@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 06:08:57 -0000 On 10/25, Zhirun Yan wrote: >Tx offload mask is updated in following commit: >commit 1037ed842c37 ("mbuf: fix Tx offload mask") >Currently, the new added offload flags will be s/will be/are Thanks, Xiaolong >not supported in PMD and application will fail to >call PMD transmit prepare function. >This patch updates IXGBE_TX_OFFFLOAD_MASK. > >Fixes: b161f72107 ("mbuf: remove too specific flags mask") >Signed-off-by: Zhirun Yan >--- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c >index e6f61c900..d6e971440 100644 >--- a/drivers/net/ixgbe/ixgbe_rxtx.c >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c >@@ -58,6 +58,10 @@ > #endif > /* Bit Mask to indicate what bits required for building TX context */ > #define IXGBE_TX_OFFLOAD_MASK ( \ >+ PKT_TX_OUTER_IPV6 | \ >+ PKT_TX_OUTER_IPV4| \ >+ PKT_TX_IPV6 | \ >+ PKT_TX_IPV4 | \ > PKT_TX_VLAN_PKT | \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ >-- >2.17.1 >