DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost
@ 2018-10-25  9:46 Tiwei Bie
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-10-25  9:46 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, dev

Tiwei Bie (2):
  net/virtio: drop duplicated reset method
  net/vhost: fix parameters string

 drivers/net/vhost/rte_eth_vhost.c       |  6 +++++-
 drivers/net/virtio/virtio_pci.c         | 15 ---------------
 drivers/net/virtio/virtio_pci.h         |  1 -
 drivers/net/virtio/virtio_user_ethdev.c |  1 -
 4 files changed, 5 insertions(+), 18 deletions(-)

-- 
2.19.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method
  2018-10-25  9:46 [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Tiwei Bie
@ 2018-10-25  9:46 ` Tiwei Bie
  2018-10-30  9:10   ` Maxime Coquelin
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string Tiwei Bie
  2018-10-30 10:56 ` [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Maxime Coquelin
  2 siblings, 1 reply; 6+ messages in thread
From: Tiwei Bie @ 2018-10-25  9:46 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, dev

Drop the duplicated reset() method in virtio_pci_ops. Currently
vtpci_reset() is implemented on set_status() and get_status()
directly. The reset() method in virtio_pci_ops isn't used and
its implementation in the legacy device isn't right.

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/virtio/virtio_pci.c         | 15 ---------------
 drivers/net/virtio/virtio_pci.h         |  1 -
 drivers/net/virtio/virtio_user_ethdev.c |  1 -
 3 files changed, 17 deletions(-)

diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
index 6bd22e54a..6a3abcd26 100644
--- a/drivers/net/virtio/virtio_pci.c
+++ b/drivers/net/virtio/virtio_pci.c
@@ -166,12 +166,6 @@ legacy_set_status(struct virtio_hw *hw, uint8_t status)
 	rte_pci_ioport_write(VTPCI_IO(hw), &status, 1, VIRTIO_PCI_STATUS);
 }
 
-static void
-legacy_reset(struct virtio_hw *hw)
-{
-	legacy_set_status(hw, VIRTIO_CONFIG_STATUS_RESET);
-}
-
 static uint8_t
 legacy_get_isr(struct virtio_hw *hw)
 {
@@ -250,7 +244,6 @@ legacy_notify_queue(struct virtio_hw *hw, struct virtqueue *vq)
 const struct virtio_pci_ops legacy_ops = {
 	.read_dev_cfg	= legacy_read_dev_config,
 	.write_dev_cfg	= legacy_write_dev_config,
-	.reset		= legacy_reset,
 	.get_status	= legacy_get_status,
 	.set_status	= legacy_set_status,
 	.get_features	= legacy_get_features,
@@ -339,13 +332,6 @@ modern_set_status(struct virtio_hw *hw, uint8_t status)
 	rte_write8(status, &hw->common_cfg->device_status);
 }
 
-static void
-modern_reset(struct virtio_hw *hw)
-{
-	modern_set_status(hw, VIRTIO_CONFIG_STATUS_RESET);
-	modern_get_status(hw);
-}
-
 static uint8_t
 modern_get_isr(struct virtio_hw *hw)
 {
@@ -438,7 +424,6 @@ modern_notify_queue(struct virtio_hw *hw __rte_unused, struct virtqueue *vq)
 const struct virtio_pci_ops modern_ops = {
 	.read_dev_cfg	= modern_read_dev_config,
 	.write_dev_cfg	= modern_write_dev_config,
-	.reset		= modern_reset,
 	.get_status	= modern_get_status,
 	.set_status	= modern_set_status,
 	.get_features	= modern_get_features,
diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
index 58fdd3d45..64ba6ecbc 100644
--- a/drivers/net/virtio/virtio_pci.h
+++ b/drivers/net/virtio/virtio_pci.h
@@ -204,7 +204,6 @@ struct virtio_pci_ops {
 			     void *dst, int len);
 	void (*write_dev_cfg)(struct virtio_hw *hw, size_t offset,
 			      const void *src, int len);
-	void (*reset)(struct virtio_hw *hw);
 
 	uint8_t (*get_status)(struct virtio_hw *hw);
 	void    (*set_status)(struct virtio_hw *hw, uint8_t status);
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 525d16cab..80af3539d 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -331,7 +331,6 @@ virtio_user_notify_queue(struct virtio_hw *hw, struct virtqueue *vq)
 const struct virtio_pci_ops virtio_user_ops = {
 	.read_dev_cfg	= virtio_user_read_dev_config,
 	.write_dev_cfg	= virtio_user_write_dev_config,
-	.reset		= virtio_user_reset,
 	.get_status	= virtio_user_get_status,
 	.set_status	= virtio_user_set_status,
 	.get_features	= virtio_user_get_features,
-- 
2.19.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string
  2018-10-25  9:46 [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Tiwei Bie
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
@ 2018-10-25  9:46 ` Tiwei Bie
  2018-10-30  9:10   ` Maxime Coquelin
  2018-10-30 10:56 ` [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Maxime Coquelin
  2 siblings, 1 reply; 6+ messages in thread
From: Tiwei Bie @ 2018-10-25  9:46 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, dev; +Cc: stable

Add the missing params to the param string.

Fixes: 39cac2adcad0 ("net/vhost: add client option")
Fixes: 4ce97c6f6b4f ("net/vhost: add an option to enable dequeue zero copy")
Fixes: 447e0d379756 ("net/vhost: add parameter to enable IOMMU feature")
Fixes: 6d6e95cec455 ("net/vhost: add parameter to enable postcopy")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 55e51c89a..07a9c2598 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1470,7 +1470,11 @@ RTE_PMD_REGISTER_VDEV(net_vhost, pmd_vhost_drv);
 RTE_PMD_REGISTER_ALIAS(net_vhost, eth_vhost);
 RTE_PMD_REGISTER_PARAM_STRING(net_vhost,
 	"iface=<ifc> "
-	"queues=<int>");
+	"queues=<int> "
+	"client=<0|1> "
+	"dequeue-zero-copy=<0|1> "
+	"iommu-support=<0|1> "
+	"postcopy-support=<0|1>");
 
 RTE_INIT(vhost_init_log)
 {
-- 
2.19.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
@ 2018-10-30  9:10   ` Maxime Coquelin
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2018-10-30  9:10 UTC (permalink / raw)
  To: Tiwei Bie, zhihong.wang, dev



On 10/25/18 11:46 AM, Tiwei Bie wrote:
> Drop the duplicated reset() method in virtio_pci_ops. Currently
> vtpci_reset() is implemented on set_status() and get_status()
> directly. The reset() method in virtio_pci_ops isn't used and
> its implementation in the legacy device isn't right.
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/virtio/virtio_pci.c         | 15 ---------------
>   drivers/net/virtio/virtio_pci.h         |  1 -
>   drivers/net/virtio/virtio_user_ethdev.c |  1 -
>   3 files changed, 17 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string Tiwei Bie
@ 2018-10-30  9:10   ` Maxime Coquelin
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2018-10-30  9:10 UTC (permalink / raw)
  To: Tiwei Bie, zhihong.wang, dev; +Cc: stable



On 10/25/18 11:46 AM, Tiwei Bie wrote:
> Add the missing params to the param string.
> 
> Fixes: 39cac2adcad0 ("net/vhost: add client option")
> Fixes: 4ce97c6f6b4f ("net/vhost: add an option to enable dequeue zero copy")
> Fixes: 447e0d379756 ("net/vhost: add parameter to enable IOMMU feature")
> Fixes: 6d6e95cec455 ("net/vhost: add parameter to enable postcopy")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/net/vhost/rte_eth_vhost.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 55e51c89a..07a9c2598 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -1470,7 +1470,11 @@ RTE_PMD_REGISTER_VDEV(net_vhost, pmd_vhost_drv);
>   RTE_PMD_REGISTER_ALIAS(net_vhost, eth_vhost);
>   RTE_PMD_REGISTER_PARAM_STRING(net_vhost,
>   	"iface=<ifc> "
> -	"queues=<int>");
> +	"queues=<int> "
> +	"client=<0|1> "
> +	"dequeue-zero-copy=<0|1> "
> +	"iommu-support=<0|1> "
> +	"postcopy-support=<0|1>");
>   
>   RTE_INIT(vhost_init_log)
>   {
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost
  2018-10-25  9:46 [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Tiwei Bie
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
  2018-10-25  9:46 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string Tiwei Bie
@ 2018-10-30 10:56 ` Maxime Coquelin
  2 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2018-10-30 10:56 UTC (permalink / raw)
  To: Tiwei Bie, zhihong.wang, dev



On 10/25/18 11:46 AM, Tiwei Bie wrote:
> Tiwei Bie (2):
>    net/virtio: drop duplicated reset method
>    net/vhost: fix parameters string
> 
>   drivers/net/vhost/rte_eth_vhost.c       |  6 +++++-
>   drivers/net/virtio/virtio_pci.c         | 15 ---------------
>   drivers/net/virtio/virtio_pci.h         |  1 -
>   drivers/net/virtio/virtio_user_ethdev.c |  1 -
>   4 files changed, 5 insertions(+), 18 deletions(-)
> 

Applied to dpdk-next-virtio/master

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-10-30 10:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25  9:46 [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Tiwei Bie
2018-10-25  9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
2018-10-30  9:10   ` Maxime Coquelin
2018-10-25  9:46 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string Tiwei Bie
2018-10-30  9:10   ` Maxime Coquelin
2018-10-30 10:56 ` [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).