From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5E9062E81 for ; Thu, 25 Oct 2018 12:59:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BCF3890C93; Thu, 25 Oct 2018 10:59:18 +0000 (UTC) Received: from localhost (ovpn-117-136.ams2.redhat.com [10.36.117.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D3845DD6C; Thu, 25 Oct 2018 10:59:15 +0000 (UTC) Date: Thu, 25 Oct 2018 12:59:13 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com Message-ID: <20181025105913.ig3s4ewuznzt4ugr@jenstp.localdomain> References: <20181024143236.21271-1-jfreimann@redhat.com> <20181024143236.21271-6-jfreimann@redhat.com> <896de2a5-8cf4-0118-7743-3ccc32c8f205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <896de2a5-8cf4-0118-7743-3ccc32c8f205@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 Oct 2018 10:59:18 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 10:59:19 -0000 On Wed, Oct 24, 2018 at 06:55:15PM +0200, Maxime Coquelin wrote: > > >On 10/24/18 4:32 PM, Jens Freimann wrote: >>diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c >>index eb891433e..837457243 100644 >>--- a/drivers/net/virtio/virtio_rxtx.c >>+++ b/drivers/net/virtio/virtio_rxtx.c >>@@ -88,6 +88,42 @@ vq_ring_free_chain(struct virtqueue *vq, uint16_t desc_idx) >> dp->next = VQ_RING_DESC_CHAIN_END; >> } >>+void >>+vq_ring_free_chain_packed(struct virtqueue *vq, uint16_t desc_idx, used_idx) >>+{ >>+ struct vring_desc_packed *dp; >>+ struct vq_desc_extra *dxp = NULL, *dxp_tail = NULL; >>+ uint16_t desc_idx_last = desc_idx; >>+ int i = 0; >>+ >>+ dp = &vq->vq_ring.desc_packed[used_idx]; >>+ dxp = &vq->vq_descx[desc_idx]; >>+ vq->vq_free_cnt = (uint16_t)(vq->vq_free_cnt + dxp->ndescs); >>+ if ((dp->flags & VRING_DESC_F_INDIRECT) == 0) { >>+ while (dp->flags & VRING_DESC_F_NEXT && i < dxp->ndescs) { >>+ desc_idx_last = dxp->next; >>+ dp = &vq->vq_ring.desc_packed[dxp->next]; >>+ dxp = &vq->vq_descx[dxp->next]; >>+ i++; >>+ } >>+ } > >Haven't you missed to squash some changes you did? >It seems you made some changes on your github branch to take Tiwei's >comment on v8 into account, but it is not here (i.e. you can't use >VRING_DESC_F_NEXT here). I sent updated versions of patch 5 and 6 and added a new branch on github https://github.com/jensfr/dpdk/tree/virtio-1.1-v10 regards, Jens