From: Jens Freimann <jfreimann@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v9 4/8] net/virtio: dump packed virtqueue data
Date: Thu, 25 Oct 2018 15:54:44 +0200 [thread overview]
Message-ID: <20181025135444.ckans6yggoykaca7@jenstp.localdomain> (raw)
In-Reply-To: <20181025092539.GD22179@debian>
On Thu, Oct 25, 2018 at 05:25:40PM +0800, Tiwei Bie wrote:
>On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote:
>> Add support to dump packed virtqueue data to the
>> VIRTQUEUE_DUMP() macro.
>>
>> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> drivers/net/virtio/virtqueue.h | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
>> index 3d512fe30..2af1bc259 100644
>> --- a/drivers/net/virtio/virtqueue.h
>> +++ b/drivers/net/virtio/virtqueue.h
>> @@ -368,6 +368,15 @@ virtqueue_notify(struct virtqueue *vq)
>> uint16_t used_idx, nused; \
>> used_idx = (vq)->vq_ring.used->idx; \
>> nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \
>> + if (vtpci_packed_queue((vq)->hw)) { \
>> + PMD_INIT_LOG(DEBUG, \
>> + "VQ: - size=%d; free=%d; used_cons_idx=%d; avail_idx=%d;" \
>> + "VQ: - avail_wrap_counter=%d; used_wrap_counter=%d", \
>
>Please remove the second "VQ: -" as they are on the same line.
ok
regards,
Jens
next prev parent reply other threads:[~2018-10-25 13:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 14:32 [dpdk-dev] [PATCH v9 0/8] implement packed virtqueues Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues Jens Freimann
2018-10-25 9:21 ` Tiwei Bie
2018-10-25 13:48 ` Jens Freimann
2018-10-25 13:51 ` Maxime Coquelin
2018-10-25 15:12 ` Jens Freimann
2018-10-26 6:01 ` Tiwei Bie
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 2/8] net/virtio: add packed virtqueue defines Jens Freimann
2018-10-25 9:22 ` Tiwei Bie
2018-10-25 14:41 ` Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 3/8] net/virtio: add packed virtqueue helpers Jens Freimann
2018-10-25 9:23 ` Tiwei Bie
2018-10-25 14:40 ` Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 4/8] net/virtio: dump packed virtqueue data Jens Freimann
2018-10-25 9:25 ` Tiwei Bie
2018-10-25 13:54 ` Jens Freimann [this message]
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues Jens Freimann
2018-10-24 16:55 ` Maxime Coquelin
2018-10-25 10:59 ` Jens Freimann
2018-10-25 9:31 ` Tiwei Bie
2018-10-25 13:19 ` Jens Freimann
2018-10-25 10:46 ` Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 6/8] net/virtio: implement receive " Jens Freimann
2018-10-25 9:39 ` Tiwei Bie
2018-10-25 13:54 ` Jens Freimann
2018-10-26 5:43 ` Tiwei Bie
2018-10-31 12:46 ` Jens Freimann
2018-10-25 10:53 ` Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 7/8] net/virtio: add virtio send command packed queue support Jens Freimann
2018-10-24 14:32 ` [dpdk-dev] [PATCH v9 8/8] net/virtio: enable packed virtqueues by default Jens Freimann
2018-10-26 6:06 ` Tiwei Bie
2018-11-02 8:58 ` Jens Freimann
2018-10-25 9:44 ` [dpdk-dev] [PATCH v9 0/8] implement packed virtqueues Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025135444.ckans6yggoykaca7@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).