From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4F0A67D4A for ; Thu, 25 Oct 2018 22:44:34 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 13:44:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,425,1534834800"; d="scan'208";a="85620514" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga006.jf.intel.com with SMTP; 25 Oct 2018 13:44:29 -0700 Received: by (sSMTP sendmail emulation); Thu, 25 Oct 2018 21:44:25 +0100 Date: Thu, 25 Oct 2018 21:44:25 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Kevin Laatz , dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, Ciara Power , Brian Archbold Message-ID: <20181025204424.GA4552@bricha3-MOBL.ger.corp.intel.com> References: <20181024132725.5142-1-kevin.laatz@intel.com> <20181024160311.85457-6-kevin.laatz@intel.com> <1665076.LlyA82DdBn@xps> <3330387.zQnsHCFWfj@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3330387.zQnsHCFWfj@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 20:44:34 -0000 On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > 25/10/2018 22:29, Thomas Monjalon: > > 24/10/2018 18:03, Kevin Laatz: > > > --- a/lib/librte_telemetry/meson.build > > > +++ b/lib/librte_telemetry/meson.build > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') > > > headers = files('rte_telemetry.h', 'rte_telemetry_internal.h') > > > deps += ['metrics', 'ethdev'] > > > cflags += '-DALLOW_EXPERIMENTAL_API' > > > +jansson = cc.find_library('jansson', required: true) > > > +ext_deps += jansson > > > > I just discovered an issue when trying to compile for arm64 > > (with devtools/test-meson-builds.sh): > > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-gnu/bin/ld: > > cannot find -ljansson > > > > I am worried because it is a real blocker. > > The dependency must be optional. > Should we disable the library if jansson is not found? > Yes, it should be. Needs: jansson = cc.find_library('jansson', required: false) build = jansson.found() /Bruce