From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 33E4E5920; Fri, 26 Oct 2018 10:02:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 01:02:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,427,1534834800"; d="scan'208";a="102664625" Received: from violet.igk.intel.com ([10.102.54.177]) by fmsmga001.fm.intel.com with ESMTP; 26 Oct 2018 01:02:49 -0700 From: Darek Stojaczyk To: dev@dpdk.org Cc: Darek Stojaczyk , thomas@monjalon.net, stable@dpdk.org Date: Fri, 26 Oct 2018 09:54:59 +0200 Message-Id: <20181026075459.21637-1-dariusz.stojaczyk@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] pci: propagate exact error codes in pci_probe_all_drivers() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 08:02:51 -0000 In a couple of places we check its error code against -EEXIST, but this function returned either -1, 0, or 1. This gets critical when hotplugging a device in secondary process, while the same device is already plugged in the primary. Failing to "hotplug" it in the primary will cause the secondary to fail as well. Fixes: e9d159c3d534 ("eal: allow probing a device again") Cc: thomas@monjalon.net Cc: stable@dpdk.org Signed-off-by: Darek Stojaczyk --- drivers/bus/pci/pci_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index feb79803c..6276e5d69 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -243,7 +243,7 @@ rte_pci_detach_dev(struct rte_pci_device *dev) /* * If vendor/device ID match, call the probe() function of all - * registered driver for the given device. Return -1 if initialization + * registered driver for the given device. Return < 0 if initialization * failed, return 1 if no driver is found for this device. */ static int @@ -253,13 +253,13 @@ pci_probe_all_drivers(struct rte_pci_device *dev) int rc = 0; if (dev == NULL) - return -1; + return -EINVAL; FOREACH_DRIVER_ON_PCIBUS(dr) { rc = rte_pci_probe_one_driver(dr, dev); if (rc < 0) /* negative value is an error */ - return -1; + return rc; if (rc > 0) /* positive value means driver doesn't support it */ continue; -- 2.17.1