From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 500254CC7; Fri, 26 Oct 2018 13:11:41 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 04:11:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,427,1534834800"; d="scan'208";a="98906072" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 26 Oct 2018 04:11:38 -0700 Received: by (sSMTP sendmail emulation); Fri, 26 Oct 2018 12:11:37 +0100 Date: Fri, 26 Oct 2018 12:11:37 +0100 From: Bruce Richardson To: Beilei Xing Cc: qi.z.zhang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20181026111136.GD14620@bricha3-MOBL.ger.corp.intel.com> References: <1540453252-128654-1-git-send-email-beilei.xing@intel.com> <1540535607-115720-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540535607-115720-1-git-send-email-beilei.xing@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 11:11:41 -0000 On Fri, Oct 26, 2018 at 02:33:27PM +0800, Beilei Xing wrote: > Previously, there is instability during vector Rx if descriptor > number is not power of 2, e.g. process hang and some Rx packets > are unexpectedly empty. That's because vector Rx mode assumes Rx > descriptor number is power of 2 when doing bit mask. > This patch allows vector mode only when the number of Rx descriptor > is power of 2. > > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Beilei Xing > --- > Do we not limit our descriptor ring sizes to powers of two anyway? Is there a real need for non-power-of-2 ring sizes?