From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20073.outbound.protection.outlook.com [40.107.2.73]) by dpdk.org (Postfix) with ESMTP id 8902B2C52 for ; Fri, 26 Oct 2018 23:49:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erOV2onxZBEMDV2EhDWEHlC7iclrL/A89U55VEPyOZI=; b=MNVguyetWJad3Dwoop0N5ezyvI+OlPRikjJwnY/gb/g5oznKS7TTQ7bEdMpuZpT/Pj8fCiqs8oGmPHrkmYT/oHCyU2NSPbWDeq+XGo/N1Vfnle+fmUOdmH4DIJwF+8UxcxVqsU3UNLndG4WJWYLK3SA3VkYxua7LBpEnssGT2/g= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4076.eurprd05.prod.outlook.com (52.134.66.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Fri, 26 Oct 2018 21:49:00 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::f8a1:fcab:94f0:97cc%4]) with mapi id 15.20.1273.025; Fri, 26 Oct 2018 21:49:00 +0000 From: Yongseok Koh To: Stephen Hemminger CC: Adrien Mazarguil , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl Thread-Index: AQHUbKF/LzMRE+OeeE+UtaLfHznFUqUyEhsA Date: Fri, 26 Oct 2018 21:49:00 +0000 Message-ID: <20181026214852.GB13615@mtidpdk.mti.labs.mlnx> References: <20181025202938.4747-1-stephen@networkplumber.org> In-Reply-To: <20181025202938.4747-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0063.prod.exchangelabs.com (2603:10b6:a03:94::40) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4076; 6:0ERAfDLoDC283a1elxmL5QozbUAMmepFh+Bo4NgEQWYV0a+Mr/w9pqbNWlVPAgomumim2IJTIydN67FXAuT0HDasLgfRwkYKc27/KVZnzJyUWnI8KP6C0G5Z6gBXYFqA8biTOP3d581tL70P3I+lO7hykPO7hRj7U998lldTnAg5Naj4e+PXCruilGYGAygCVpWxu5XAwUNG7XDlBfhwr8/53K0x/oe6svPnnXOFpVBE/IAQUH3CcNvik8vGMCehwfb36z6JHuwN45ciww2pDENfTlCnmQIUzZopOYt3CbKQpep8Xu7AglturzOjKfX99cTjqnmMPvhBMGkCmbh8HuePeHoU/K9guRnUdxyZWKSzFoHk4/ybPDTlHxZVIqZEEDIXK/KkKMaiysGYfU1uyJQm60u99GE5Z8NEN4r7+lNCeQSEs2jmStCC18m3LEJyENKsg+JlsPHq6LGuwruDcw==; 5:1O5YBoqHZKBicn2OOZPUDI4eXe61D+XjkqIKsxvdO32O0cj6kaus8ixkQe2Z6Q1CO1O1CvDbipCHrWRqjBog9HUSL+/r0nLm2BXykGBSL1uI7vnMYBu2wV3aPB9DKidsMCQTtv0LQqp2OFWAL2q6db3l5K4UC9mgHWG1Pth/qgg=; 7:Ml4yguCaY0sO55KVoNRioFKuNf3mSNh6e3xdo7iUbGgbW5rrd5mJMfeKLuppWYw9UamUNCk+kNBCLXVxBrhWtOMQ25GONT4kvn7hxTXuQnY6AGNcx56NxzTop2ag8IPEPGfs2j5fRvnT4buT8g24AXaFDQ57QBzVqCvSBoiEoKZbUgX3H8M6mHdFkEPQo2kUQQbNGjw0REEAwb/DcVogZTITIWtsudfClWnfUISmhmCVBgCv0+4ZfLI/BGMmXkst x-ms-office365-filtering-correlation-id: ee84cbb0-91e9-45b8-87eb-08d63b8cd693 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4076; x-ms-traffictypediagnostic: DB3PR0502MB4076: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB4076; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4076; x-forefront-prvs: 083751FCA6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(346002)(396003)(39860400002)(199004)(189003)(6436002)(106356001)(575784001)(86362001)(6486002)(105586002)(1076002)(5250100002)(229853002)(33656002)(316002)(6916009)(6116002)(2906002)(53936002)(9686003)(3846002)(6512007)(6246003)(478600001)(256004)(14444005)(14454004)(54906003)(476003)(26005)(66066001)(99286004)(33896004)(2900100001)(305945005)(186003)(486006)(102836004)(4326008)(11346002)(446003)(7736002)(6506007)(386003)(71200400001)(71190400001)(76176011)(81156014)(8676002)(25786009)(5660300001)(8936002)(81166006)(52116002)(68736007)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4076; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Bs5zE37ll9Lfrqzgq34tJaG7HjkhxsxuzaMzSTT44H3+g8Rx4B1C31WHiCGxtAc2pRWm3jfzSCktKoUZhn5ZcxPjcMK6/dYhQeZngT6py6RJXs7YevDdrvhT5TW4u0QvgmdjhZ9ZudRzCdGRn/ZFd1cNucVremgjLp8Y3F18nb/Zc+u5hwTLjnP4SGevk7iCxRcERdlu7LoZsfKnfQ2+SFBuo0zdN54tIsTkFShTu3Q4Fmmn+Q/uOBnfI9mcqFGSZHGv2ylAWUB4aw+Peb/ilhZYQXKn/MkPBL+/srN1lIDQn3IYunuy626gjVuJsp/2UO4KGPQgk5HhGeiiKPU1a0EPjJbySoHxtTK4H4cVpEc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <7218EE8AE4D28F468AE5DC7E416C7655@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee84cbb0-91e9-45b8-87eb-08d63b8cd693 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2018 21:49:00.3738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4076 Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 21:49:04 -0000 On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote: > SUSE decided to install the libmnl include file in a non-standard > place: /usr/include/libmnl/libmnl/libmnl.h >=20 > This was probably a mistake by the SUSE package maintainer, > but hard to get fixed. Workaround the problem by pkg-config to find > the necessary include directive for libmnl. >=20 > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads") > Signed-off-by: Stephen Hemminger > --- Acked-by: Yongseok Koh Thanks > v3 - Tested on SLES 15, needs $(shell pkg-config ...)=20 >=20 > drivers/net/mlx5/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 1e9c0b42ac16..8497c98ef86e 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -51,6 +51,7 @@ CFLAGS +=3D -D_DEFAULT_SOURCE > CFLAGS +=3D -D_XOPEN_SOURCE=3D600 > CFLAGS +=3D $(WERROR_FLAGS) > CFLAGS +=3D -Wno-strict-prototypes > +CFLAGS +=3D $(shell pkg-config --cflags libmnl) > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > CFLAGS +=3D -DMLX5_GLUE=3D'"$(LIB_GLUE)"' > CFLAGS +=3D -DMLX5_GLUE_VERSION=3D'"$(LIB_GLUE_VERSION)"' > @@ -59,7 +60,7 @@ LDLIBS +=3D -ldl > else > LDLIBS +=3D -libverbs -lmlx5 > endif > -LDLIBS +=3D -lmnl > +LDLIBS +=3D $(shell pkg-config --libs libmnl) > LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > LDLIBS +=3D -lrte_bus_pci > --=20 > 2.19.1 >=20