From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 715C710A3; Sat, 27 Oct 2018 12:41:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343892" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:40:51 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye Date: Sat, 27 Oct 2018 18:40:24 +0800 Message-Id: <20181027104032.10251-1-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 10:41:08 -0000 Hi, This patch series is to correct the wrong setting of XXX_TX_OFFLOAD_MASK in multiple PMDs. Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in XXX_TX_OFFLOAD_MASK), however, xor will not get desired result here, assume bit 0 of PKT_TX_OFFLOAD_MASK and XXX_TX_OFFLOAD_MAKS are 0 which means corresponding feature is not supported in both sides, then we get value of bit 0 of XXX_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it implies that it is supported which doesn't meet our expectation. Correct it by a NOT-AND operation. Xiaolong Ye (8): net/ixgbe: correct offload not supported mask net/avf: correct offload not supported mask net/ena: correct offload not supported mask net/atlantic: correct offload not supported mask net/fm10k: correct offload not supported mask net/qede: correct offload not supported mask net/vmxnet3: correct offload not supported mask net/e1000: correct offload not supported mask drivers/net/atlantic/atl_rxtx.c | 2 +- drivers/net/avf/avf_rxtx.h | 2 +- drivers/net/e1000/em_rxtx.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- drivers/net/ena/ena_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- drivers/net/qede/qede_rxtx.h | 2 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) -- 2.17.1