DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com,
	Arnon Warshavsky <arnon@qwilt.com>
Subject: [dpdk-dev] [PATCH] devtools: check wrong svg include in patches
Date: Wed, 31 Oct 2018 12:05:48 +0100	[thread overview]
Message-ID: <20181031110548.31184-1-thomas@monjalon.net> (raw)

Including svg files with the svg extension is a common mistake:
	.. figure:: example.svg
must be
	.. figure:: example.*
So it will work also when building pdf doc with figures converted
to png files.

A check is added in checkpatches.sh.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

PS: it seems this check is not working. Arnon, I need your help please.
Cc: Arnon Warshavsky <arnon@qwilt.com>
---
 devtools/checkpatches.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index bf3114f95..e69b5bc34 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -50,6 +50,12 @@ check_forbidden_additions() {
 		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
 		-v RET_ON_FAIL=1 \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
+	# svg figures must be included with wildcard extension
+	# because of png conversion for pdf docs
+	awk -v FOLDERS='doc' \
+		-v EXPRESSIONS=':: *[^ ]*\\.svg' \
+		-v RET_ON_FAIL=1 \
+		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
 }
 
 number=0
-- 
2.19.0

             reply	other threads:[~2018-10-31 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 11:05 Thomas Monjalon [this message]
2018-10-31 15:46 ` Arnon Warshavsky
2018-10-31 15:51   ` Thomas Monjalon
2018-10-31 15:55     ` Arnon Warshavsky
2018-10-31 16:28 ` [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides Thomas Monjalon
2018-11-01  6:45   ` Arnon Warshavsky
2018-11-01  9:27     ` Thomas Monjalon
2018-11-01  9:29       ` Arnon Warshavsky
2018-11-01 13:59         ` Arnon Warshavsky
2018-11-01 14:10           ` Thomas Monjalon
2018-11-01 21:25   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031110548.31184-1-thomas@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).