From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 22A74B62 for ; Wed, 31 Oct 2018 12:05:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8C18C223E0; Wed, 31 Oct 2018 07:05:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 31 Oct 2018 07:05:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=0O5HHxsgkRFLPYWg75Ls1R0 r8WIy/3Ctqj/YmZIuaGc=; b=iSYTidtmWMOvaAxdqlciCy8tgrdqcLAVI7XOOfM O0GJH7f+TVnFBRIW6c7AG+C0YBPj2korm8TGmSTi7NWxqKlE9JtLVNq240eswbIG zMFxJN+iDoa/GIWmY5KLe4m/Ubje9VA0GFXFCX/aVkwOvocFMWhepeVvBsjXR8h5 r73k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0O5HHxsgkRFLPYWg7 5Ls1R0r8WIy/3Ctqj/YmZIuaGc=; b=o/1Sbl+ZCltmZy+0gVLYcXsnwaRVf8OLh l1dweMXbCYEPti35Uh9EI1FVbjAkwt9Z7N/cLYmCHHr9IQRqsiZe/moAggu4kend 0MW2Y7+F+FI1sExZINvrFiRQi9dIFxCa3r/LQf/md0iuciRtNdiNaGGZgokCUQmx JQFLM8YfuFNHMx1RexBtNcIV2xowmP+kJ/65tLj4a8GCki2916S+QVk29r/o0L9u Y31iaSlO1+pw/DDPhNxoBbbj8T5Z9LxG20nbaohm/f1DCfvH25aJ7Kj6arGhRtRh vvc5WsSM7iLr2Ct9Z1FqxXTkdlQ/g3TUSKh3dypCYcjKcrhDa79AA== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 43B2B102A0; Wed, 31 Oct 2018 07:05:57 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, Arnon Warshavsky Date: Wed, 31 Oct 2018 12:05:48 +0100 Message-Id: <20181031110548.31184-1-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] devtools: check wrong svg include in patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 11:05:59 -0000 Including svg files with the svg extension is a common mistake: .. figure:: example.svg must be .. figure:: example.* So it will work also when building pdf doc with figures converted to png files. A check is added in checkpatches.sh. Signed-off-by: Thomas Monjalon PS: it seems this check is not working. Arnon, I need your help please. Cc: Arnon Warshavsky --- devtools/checkpatches.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index bf3114f95..e69b5bc34 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -50,6 +50,12 @@ check_forbidden_additions() { -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \ -v RET_ON_FAIL=1 \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk - + # svg figures must be included with wildcard extension + # because of png conversion for pdf docs + awk -v FOLDERS='doc' \ + -v EXPRESSIONS=':: *[^ ]*\\.svg' \ + -v RET_ON_FAIL=1 \ + -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk - } number=0 -- 2.19.0