DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gaëtan Rivet <gaetan.rivet@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Cody Doucette <doucette@bu.edu>,
	Matan Azrad <matan@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag
Date: Wed, 31 Oct 2018 22:10:39 +0100
Message-ID: <20181031211039.weuadluvjobssqbn@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1585740.4slmyqDWMi@xps>

On Wed, Oct 31, 2018 at 06:02:29PM +0100, Thomas Monjalon wrote:
> 31/10/2018 03:17, Cody Doucette:
> > Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to
> > build when changing some DPDK libraries. The flag is not needed
> > and therefore is removed.
> > 
> > Signed-off-by: Cody Doucette <doucette@bu.edu>
> 
> Gaetan, please approve that the flag is not needed.
> 

I suspected popen or fgets from failsafe_args.c, but I wasn't able
to find a reason for the define. I can't remember the initial reason for
it, sorry.

I have tested the build on linux and freebsd, without issue, so at this
point I think this is ok.

-- 
Gaëtan Rivet
6WIND

  reply	other threads:[~2018-10-31 21:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31  2:17 [dpdk-dev] [PATCH v5 0/3] Extend rte_ipv6_frag_get_ipv6_fragment_header() Cody Doucette
2018-10-31  2:17 ` [dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag Cody Doucette
2018-10-31 17:02   ` Thomas Monjalon
2018-10-31 21:10     ` Gaëtan Rivet [this message]
2018-10-31  2:17 ` [dpdk-dev] [PATCH v5 2/3] net: add IPv6 extension header definitions Cody Doucette
2018-10-31 17:03   ` Thomas Monjalon
2018-11-05  8:45     ` Olivier Matz
2018-10-31  2:17 ` [dpdk-dev] [PATCH v5 3/3] ip_frag: extend IPv6 fragment header retrieval Cody Doucette
2018-10-31 17:03   ` Thomas Monjalon
2018-10-31 19:56   ` Ananyev, Konstantin
2018-11-07 20:21     ` Cody Doucette
2018-11-07 23:00       ` Ananyev, Konstantin
  -- strict thread matches above, loose matches on Subject: below --
2018-10-31  0:17 [dpdk-dev] [PATCH v4 0/3] Extend rte_ipv6_frag_get_ipv6_fragment_header() Cody Doucette
2018-10-31  0:17 ` [dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag Cody Doucette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031211039.weuadluvjobssqbn@bidouze.vm.6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=dev@dpdk.org \
    --cc=doucette@bu.edu \
    --cc=matan@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git