From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 11B32DED for ; Wed, 31 Oct 2018 22:11:01 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id p2-v6so15747353wmc.2 for ; Wed, 31 Oct 2018 14:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mFPQsFz1CJwvjZVE0t1y1eE8LZDRKzI8UaWkfZ6JIyE=; b=IlW3Drh5eL50skhU1vweYErDjx1/CEKkFTU0cTZnJ8FqcLkOAU/mEoYuqiMp5Gx8WP TxlDSVLnbF4V4RoSUJmS1Y/jEt3wOS8shaaNfgCAWQfmT2BASEXPM0OcFztS/YmtCg4f Cif08Ewl3daCwqKqTE91PtfjxABL1GQubttrZIVaWWyC1eU1kIudokuEcVZKQW65T6w7 EdJpmiHSd1aKM2CEv5Ahrw7t96on+Yk1hCWXtztB/s5GyBdTJBflw9zSiTSbw+GmwWxQ NQ0PgoljRifhoF8MlqjNcNE2nKuPwB10/r6lq7Gv/m8V9g7D8Q3DorVbQBN6uLAYHLtv w6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mFPQsFz1CJwvjZVE0t1y1eE8LZDRKzI8UaWkfZ6JIyE=; b=cTEFH2WLpnzUkFD5Agu04n5G+x3msWVA0tpgYWLOEohXB0t2RSNjGVi2VRNWygBjKg MHaCnaa6+nuHtYOnRmC65ArSbewr4JftXHlQXJ9+NnwPzeq9tzGeKGeFw792V5ZBetd8 u//JLFGk/1IZRuiAvWJg07U1PtYMuVIPWSoAsHldM5cccqDg8cf/FLYnsoco1FmhF8m+ KYUzlngpm6QxUuNpBvpU+u9NS1VY8jW9cNJur09Sdzij91lTNMfM7WasVfyu1+nIcU/4 p2cEG1TKtlVwxZ/YX2eqN4y0MG157AF3rf7TT++6D5atkQ+xvEEYC2gea7x08/8B4o3V AC5A== X-Gm-Message-State: AGRZ1gJWsYu0+nsQCnsDMgFc46NqrISasLoH7Mbcjsn8wmn/ULw2oYNm CxhZZPzZhURQuc/dBYHyiKxqPw== X-Google-Smtp-Source: AJdET5cxmvO3wgYpeZiShFgynWX4HZOeHyA+oHXipIt+M4ifuqW9I3pPvsXCeYOcRNP2biXgpdB8fg== X-Received: by 2002:a1c:6c0f:: with SMTP id h15-v6mr3474825wmc.123.1541020260085; Wed, 31 Oct 2018 14:11:00 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r73-v6sm20461741wmb.37.2018.10.31.14.10.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Oct 2018 14:10:59 -0700 (PDT) Date: Wed, 31 Oct 2018 22:10:39 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org, Cody Doucette , Matan Azrad Message-ID: <20181031211039.weuadluvjobssqbn@bidouze.vm.6wind.com> References: <20181031021758.66752-1-doucette@bu.edu> <20181031021758.66752-2-doucette@bu.edu> <1585740.4slmyqDWMi@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1585740.4slmyqDWMi@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 21:11:01 -0000 On Wed, Oct 31, 2018 at 06:02:29PM +0100, Thomas Monjalon wrote: > 31/10/2018 03:17, Cody Doucette: > > Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to > > build when changing some DPDK libraries. The flag is not needed > > and therefore is removed. > > > > Signed-off-by: Cody Doucette > > Gaetan, please approve that the flag is not needed. > I suspected popen or fgets from failsafe_args.c, but I wasn't able to find a reason for the define. I can't remember the initial reason for it, sorry. I have tested the build on linux and freebsd, without issue, so at this point I think this is ok. -- Gaëtan Rivet 6WIND