From: Stephen Hemminger <stephen@networkplumber.org>
To: wei zhao <wei.zhao1@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: check jumbo frame enable parameter
Date: Thu, 1 Nov 2018 10:46:08 -0700 [thread overview]
Message-ID: <20181101104608.31a9d102@xeon-e3> (raw)
In-Reply-To: <1541058926-3576-1-git-send-email-wei.zhao1@intel.com>
On Thu, 1 Nov 2018 15:55:26 +0800
wei zhao <wei.zhao1@intel.com> wrote:
> + /* check that max packet size is within the allowed range */
> + if (max_rx_pkt_len < ETHER_MIN_MTU) {
> + PMD_INIT_LOG(ERR, "max packet size is too small.");
> + return -EINVAL;
> + }
> +
> + if (max_rx_pkt_len > dev_info.max_rx_pktlen) {
> + PMD_INIT_LOG(ERR, "max packet size is too big.");
> + return -EINVAL;
> + }
> +
> + /* check jumbo mode if needed */
> + if (max_rx_pkt_len < ETHER_MAX_LEN) {
> + PMD_INIT_LOG(ERR, "No need to enable jumbo.");
> + return -EINVAL;
> + }
> +
Yes, these checks are needed and for other devices as well.
Why not add them into rte_ethdev instead?
next prev parent reply other threads:[~2018-11-01 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 7:55 wei zhao
2018-11-01 8:28 ` [dpdk-dev] [PATCH v2] " wei zhao
2018-11-01 8:40 ` Zhao1, Wei
2018-11-05 16:34 ` Zhang, Qi Z
2018-11-06 2:49 ` Zhao1, Wei
2018-11-01 17:46 ` Stephen Hemminger [this message]
2018-11-05 9:13 ` [dpdk-dev] [PATCH] " Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101104608.31a9d102@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).