DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net: fix compilation with GRE header
@ 2018-11-01 12:46 Shahaf Shuler
  2018-11-02 14:56 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Shahaf Shuler @ 2018-11-01 12:46 UTC (permalink / raw)
  To: ferruh.yigit, olivier.matz; +Cc: dev, stable

The following error popped when compiling with -pedantic:

In file included from
/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/
mlx5/mlx5_flow_dv.c:28:0:
/.autodirect/swgwork/shahafs/workspace/dpdk.org/
build/include/rte_gre.h:20:2:
error: type of bit-field 'res2' is a GCC  extension [-Werror=pedantic]
 uint16_t res2:4; /**< Reserved */

Fixing by adding the __extension__ attribute.

Fixes: 894f71a3805d ("net: add GRE header structure")
Cc: stable@dpdk.org
Cc: olivier.matz@6wind.com

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 lib/librte_net/rte_gre.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_net/rte_gre.h b/lib/librte_net/rte_gre.h
index 69499bb82a..05aa9d143e 100644
--- a/lib/librte_net/rte_gre.h
+++ b/lib/librte_net/rte_gre.h
@@ -15,6 +15,7 @@ extern "C" {
 /**
  * GRE Header
  */
+__extension__
 struct gre_hdr {
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
 	uint16_t res2:4; /**< Reserved */
-- 
2.12.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net: fix compilation with GRE header
  2018-11-01 12:46 [dpdk-dev] [PATCH] net: fix compilation with GRE header Shahaf Shuler
@ 2018-11-02 14:56 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-11-02 14:56 UTC (permalink / raw)
  To: Shahaf Shuler, olivier.matz; +Cc: dev, stable

On 11/1/2018 12:46 PM, Shahaf Shuler wrote:
> The following error popped when compiling with -pedantic:
> 
> In file included from
> /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/
> mlx5/mlx5_flow_dv.c:28:0:
> /.autodirect/swgwork/shahafs/workspace/dpdk.org/
> build/include/rte_gre.h:20:2:
> error: type of bit-field 'res2' is a GCC  extension [-Werror=pedantic]
>  uint16_t res2:4; /**< Reserved */
> 
> Fixing by adding the __extension__ attribute.
> 
> Fixes: 894f71a3805d ("net: add GRE header structure")
> Cc: stable@dpdk.org
> Cc: olivier.matz@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-02 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 12:46 [dpdk-dev] [PATCH] net: fix compilation with GRE header Shahaf Shuler
2018-11-02 14:56 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).