From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 005F05F11 for ; Thu, 1 Nov 2018 15:16:55 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 07:16:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,452,1534834800"; d="scan'208";a="82642715" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga007.fm.intel.com with SMTP; 01 Nov 2018 07:16:52 -0700 Received: by (sSMTP sendmail emulation); Thu, 01 Nov 2018 14:16:51 +0000 Date: Thu, 1 Nov 2018 14:16:51 +0000 From: Bruce Richardson To: Jerin Jacob Cc: Fiona Trahe , "dev@dpdk.org" , "thomas@monjalon.net" , "akhil.goyal@nxp.com" , "tomaszx.jozwiak@intel.com" Message-ID: <20181101141650.GA11468@bricha3-MOBL.ger.corp.intel.com> References: <20181027164739.13110-1-jerin.jacob@caviumnetworks.com> <1540946394-22196-1-git-send-email-fiona.trahe@intel.com> <20181031063503.GA21779@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181031063503.GA21779@jerin> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 14:16:56 -0000 On Wed, Oct 31, 2018 at 06:35:11AM +0000, Jerin Jacob wrote: > -----Original Message----- > > Date: Wed, 31 Oct 2018 00:39:54 +0000 > > From: Fiona Trahe > > To: dev@dpdk.org > > CC: thomas@monjalon.net, akhil.goyal@nxp.com, tomaszx.jozwiak@intel.com, > > jerin.jacob@caviumnetworks.com, Fiona Trahe > > Subject: [PATCH] compress/qat: fix out-of-bounds error > > X-Mailer: git-send-email 1.7.0.7 > > > > > > QAT array for sgls in intermediate buffer structure > > was #defined to 1, but setup code hardcoded as if 2 buffers > > so causing out of bounds write. Reworked to loop correctly > > using #define. > > > > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") > > > > Reported-by: Jerin Jacob > > Signed-off-by: Fiona Trahe > > clang build is not reproducible with this patch. s/not/now/ :-) > > Tested-by: Jerin Jacob > I can also confirm that clang builds which were failing without this patch are now building ok on Fedora 29. Acked-by: Bruce Richardson