From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4B50E683E for ; Thu, 1 Nov 2018 15:46:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EAA8021E81; Thu, 1 Nov 2018 10:46:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 01 Nov 2018 10:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=J5GoonNrOC B5+7SXdubkFCoA8Od5/9OKbNIgWs6q46c=; b=OrVTwUNkqyXd/eW8MdJjYlIeUw Y9wGrlp1VlQUQ3504ej1dzLvT23mHPNXc6prgIH9mNY424VNM7b+iQ96SIRhNad1 rcTzTueQSTgJ4LN8zFB1rJFoy8UJHja9V/uHP05TMiUVSWwjtaQBXH5ZCuCPnHRM Z7udGBw4Zn1DKZw3U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=J5GoonNrOCB5+7SXdubkFCoA8Od5/9OKbNIgWs6q46c=; b=Z0R54ao9 nGmb+KkP/RccFZED6GfQ90+Gio/kGi08xAtltJgitdyO791KnhDUEJkIHO3yKjhC 3dpiNk1uLavALhPgWAimQeXSX6fCqElXwj6l/y3kr2aXsBP8IgBw2gLmUiukpsUc XopXe8olPimq/79xw6KpSQvPyyX3B+r52/+3Qg8toi6AuJ42r2ZV5W3q/EuMi98R frs+5JqX7kK+AUyf3LSjo88ghh85PRxa8M+uxx8pUfyAn6dg6V/QDLDVW9PI/U3w KrVuTDsciQ26qMPUI3wxL/50xklwsfLCjVGKVENgzLI9EJXpbRL8pxN/NozIj2uw sY0hDdBXp6l6lQ== X-ME-Sender: X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D934B10412; Thu, 1 Nov 2018 10:46:49 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ktraynor@redhat.com, ian.stokes@intel.com Date: Thu, 1 Nov 2018 15:46:32 +0100 Message-Id: <20181101144633.13429-2-thomas@monjalon.net> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181101144633.13429-1-thomas@monjalon.net> References: <20181101144633.13429-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 14:46:51 -0000 The functions rte_dev_probe() and rte_dev_remove() are new in DPDK 18.11 so they got the experimental tag by policy. However they are too much basic functions for being skipped by strict applications which do not use experimental functions. The alternative is to use rte_eal_hotplug_add() and rte_eal_hotplug_remove(), but their API requires the application to parse the devargs string in order to provide bus name, device name and driver arguments. The new function rte_dev_probe() is really simpler to use and more flexible by accepting any devargs string. Let's encourage applications to use it. The old functions rte_eal_hotplug_* may be deprecated later. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_dev.c | 4 ++-- lib/librte_eal/common/include/rte_dev.h | 10 ++-------- lib/librte_eal/rte_eal_version.map | 4 ++-- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 62e9ed477..5759ec2d8 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -186,7 +186,7 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev) return ret; } -int __rte_experimental +int rte_dev_probe(const char *devargs) { struct eal_dev_mp_req req; @@ -322,7 +322,7 @@ local_dev_remove(struct rte_device *dev) return 0; } -int __rte_experimental +int rte_dev_remove(struct rte_device *dev) { struct eal_dev_mp_req req; diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index cd6c187cc..a9724dc91 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -196,9 +196,6 @@ int rte_eal_hotplug_add(const char *busname, const char *devname, const char *drvargs); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Add matching devices. * * In multi-process, it will request other processes to add the same device. @@ -209,7 +206,7 @@ int rte_eal_hotplug_add(const char *busname, const char *devname, * @return * 0 on success, negative on error. */ -int __rte_experimental rte_dev_probe(const char *devargs); +int rte_dev_probe(const char *devargs); /** * Hotplug remove a given device from a specific bus. @@ -227,9 +224,6 @@ int __rte_experimental rte_dev_probe(const char *devargs); int rte_eal_hotplug_remove(const char *busname, const char *devname); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Remove one device. * * In multi-process, it will request other processes to remove the same device. @@ -240,7 +234,7 @@ int rte_eal_hotplug_remove(const char *busname, const char *devname); * @return * 0 on success, negative on error. */ -int __rte_experimental rte_dev_remove(struct rte_device *dev); +int rte_dev_remove(struct rte_device *dev); /** * Device comparison function. diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index 04f624246..be4976e3d 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -262,6 +262,8 @@ DPDK_18.11 { rte_eal_get_runtime_dir; rte_eal_hotplug_add; rte_eal_hotplug_remove; + rte_dev_probe; + rte_dev_remove; rte_strscpy; } DPDK_18.08; @@ -285,8 +287,6 @@ EXPERIMENTAL { rte_dev_is_probed; rte_dev_iterator_init; rte_dev_iterator_next; - rte_dev_probe; - rte_dev_remove; rte_devargs_add; rte_devargs_dump; rte_devargs_insert; -- 2.19.0