From: Yongseok Koh <yskoh@mellanox.com> To: Slava Ovsiienko <viacheslavo@mellanox.com> Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v3 04/13] net/mlx5: add necessary structures for e-switch VXLAN Date: Thu, 1 Nov 2018 20:36:23 +0000 Message-ID: <20181101203615.GE6118@mtidpdk.mti.labs.mlnx> (raw) In-Reply-To: <1541074741-41368-5-git-send-email-viacheslavo@mellanox.com> On Thu, Nov 01, 2018 at 05:19:25AM -0700, Slava Ovsiienko wrote: > This patch introduces the data structures needed to implement VXLAN > encapsulation/decapsulation hardware offload support for E-Switch. > > Suggested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > --- Acked-by: Yongseok Koh <yskoh@mellanox.com> Thanks > drivers/net/mlx5/mlx5_flow.h | 9 ++++ > drivers/net/mlx5/mlx5_flow_tcf.c | 99 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 108 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 392c525..3887ee9 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -191,6 +191,15 @@ struct mlx5_flow_dv { > struct mlx5_flow_tcf { > struct nlmsghdr *nlh; > struct tcmsg *tcm; > + union { /**< Tunnel encap/decap descriptor. */ > + struct flow_tcf_tunnel_hdr *tunnel; > + struct flow_tcf_vxlan_decap *vxlan_decap; > + struct flow_tcf_vxlan_encap *vxlan_encap; > + }; > + uint32_t applied:1; /**< Whether rule is currently applied. */ > +#ifndef NDEBUG > + uint32_t nlsize; /**< Size of NL message buffer for debug check. */ > +#endif > }; > > /* Verbs specification header. */ > diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c > index 4d54112..55c77e3 100644 > --- a/drivers/net/mlx5/mlx5_flow_tcf.c > +++ b/drivers/net/mlx5/mlx5_flow_tcf.c > @@ -348,6 +348,100 @@ struct mlx5_flow_tcf_context { > uint8_t *buf; /* Message buffer. */ > }; > > +/** > + * Neigh rule structure. The neigh rule is applied via Netlink to > + * outer tunnel iface in order to provide destination MAC address > + * for the VXLAN encapsultion. The neigh rule is implicitly related > + * to the Flow itself and can be shared by multiple Flows. > + */ > +struct tcf_neigh_rule { > + LIST_ENTRY(tcf_neigh_rule) next; > + uint32_t refcnt; > + struct ether_addr eth; > + uint16_t mask; > + union { > + struct { > + rte_be32_t dst; > + } ipv4; > + struct { > + uint8_t dst[IPV6_ADDR_LEN]; > + } ipv6; > + }; > +}; > + > +/** > + * Local rule structure. The local rule is applied via Netlink to > + * outer tunnel iface in order to provide local and peer IP addresses > + * of the VXLAN tunnel for encapsulation. The local rule is implicitly > + * related to the Flow itself and can be shared by multiple Flows. > + */ > +struct tcf_local_rule { > + LIST_ENTRY(tcf_local_rule) next; > + uint32_t refcnt; > + uint16_t mask; > + union { > + struct { > + rte_be32_t dst; > + rte_be32_t src; > + } ipv4; > + struct { > + uint8_t dst[IPV6_ADDR_LEN]; > + uint8_t src[IPV6_ADDR_LEN]; > + } ipv6; > + }; > +}; > + > +/** VXLAN virtual netdev. */ > +struct tcf_vtep { > + LIST_ENTRY(tcf_vtep) next; > + LIST_HEAD(, tcf_neigh_rule) neigh; > + LIST_HEAD(, tcf_local_rule) local; > + uint32_t refcnt; > + unsigned int ifindex; /**< Own interface index. */ > + unsigned int ifouter; /**< Index of device attached to. */ > + uint16_t port; > + uint8_t created; > +}; > + > +/** Tunnel descriptor header, common for all tunnel types. */ > +struct flow_tcf_tunnel_hdr { > + uint32_t type; /**< Tunnel action type. */ > + struct tcf_vtep *vtep; /**< Virtual tunnel endpoint device. */ > + unsigned int ifindex_org; /**< Original dst/src interface */ > + unsigned int *ifindex_ptr; /**< Interface ptr in message. */ > +}; > + > +struct flow_tcf_vxlan_decap { > + struct flow_tcf_tunnel_hdr hdr; > + uint16_t udp_port; > +}; > + > +struct flow_tcf_vxlan_encap { > + struct flow_tcf_tunnel_hdr hdr; > + uint32_t mask; > + struct { > + struct ether_addr dst; > + struct ether_addr src; > + } eth; > + union { > + struct { > + rte_be32_t dst; > + rte_be32_t src; > + } ipv4; > + struct { > + uint8_t dst[IPV6_ADDR_LEN]; > + uint8_t src[IPV6_ADDR_LEN]; > + } ipv6; > + }; > +struct { > + rte_be16_t src; > + rte_be16_t dst; > + } udp; > + struct { > + uint8_t vni[3]; > + } vxlan; > +}; > + > /** Structure used when extracting the values of a flow counters > * from a netlink message. > */ > @@ -365,6 +459,7 @@ struct flow_tcf_stats_basic { > struct rte_flow_item_ipv6 ipv6; > struct rte_flow_item_tcp tcp; > struct rte_flow_item_udp udp; > + struct rte_flow_item_vxlan vxlan; > } flow_tcf_mask_empty; > > /** Supported masks for known item types. */ > @@ -376,6 +471,7 @@ struct flow_tcf_stats_basic { > struct rte_flow_item_ipv6 ipv6; > struct rte_flow_item_tcp tcp; > struct rte_flow_item_udp udp; > + struct rte_flow_item_vxlan vxlan; > } flow_tcf_mask_supported = { > .port_id = { > .id = 0xffffffff, > @@ -413,6 +509,9 @@ struct flow_tcf_stats_basic { > .src_port = RTE_BE16(0xffff), > .dst_port = RTE_BE16(0xffff), > }, > + .vxlan = { > + .vni = "\xff\xff\xff", > + }, > }; > > #define SZ_NLATTR_HDR MNL_ALIGN(sizeof(struct nlattr)) > -- > 1.8.3.1 >
next prev parent reply other threads:[~2018-11-01 20:36 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 6:30 [dpdk-dev] [PATCH 1/5] net/mlx5: add VXLAN encap/decap support for e-switch Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 2/5] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 3/5] net/mlx5: e-switch VXLAN flow validation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 4/5] net/mlx5: e-switch VXLAN flow translation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 5/5] net/mlx5: e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 0/7] net/mlx5: e-switch VXLAN encap/decap hardware offload Viacheslav Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions Viacheslav Ovsiienko 2018-10-23 10:01 ` Yongseok Koh 2018-10-25 12:50 ` Slava Ovsiienko 2018-10-25 23:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine Viacheslav Ovsiienko 2018-10-23 10:04 ` Yongseok Koh 2018-10-25 13:53 ` Slava Ovsiienko 2018-10-26 3:07 ` Yongseok Koh 2018-10-26 8:39 ` Slava Ovsiienko 2018-10-26 21:56 ` Yongseok Koh 2018-10-29 9:33 ` Slava Ovsiienko 2018-10-29 18:26 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine Viacheslav Ovsiienko 2018-10-23 10:06 ` Yongseok Koh 2018-10-25 14:37 ` Slava Ovsiienko 2018-10-26 4:22 ` Yongseok Koh 2018-10-26 9:06 ` Slava Ovsiienko 2018-10-26 22:10 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 4/7] net/mlx5: e-switch VXLAN netlink routines update Viacheslav Ovsiienko 2018-10-23 10:07 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management Viacheslav Ovsiienko 2018-10-25 0:28 ` Yongseok Koh 2018-10-25 20:21 ` Slava Ovsiienko 2018-10-26 6:25 ` Yongseok Koh 2018-10-26 9:35 ` Slava Ovsiienko 2018-10-26 22:42 ` Yongseok Koh 2018-10-29 11:53 ` Slava Ovsiienko 2018-10-29 18:42 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 6/7] net/mlx5: e-switch VXLAN encapsulation rules management Viacheslav Ovsiienko 2018-10-25 0:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines Viacheslav Ovsiienko 2018-10-25 0:36 ` Yongseok Koh 2018-10-25 20:32 ` Slava Ovsiienko 2018-10-26 6:30 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 01/13] net/mlx5: prepare makefile for adding e-switch VXLAN Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 02/13] net/mlx5: prepare meson.build " Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-01 20:35 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-01 20:36 ` Yongseok Koh [this message] 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 05/13] net/mlx5: swap items/actions validations for e-switch rules Slava Ovsiienko 2018-11-01 20:37 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 06/13] net/mlx5: add e-switch VXLAN support to validation routine Slava Ovsiienko 2018-11-01 20:49 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-01 21:03 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-01 21:18 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 09/13] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-11-01 21:21 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 10/13] net/mlx5: fix e-switch Flow counter deletion Slava Ovsiienko 2018-11-01 22:00 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 11/13] net/mlx5: add e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-01 23:59 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 12/13] net/mlx5: add e-switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 13/13] net/mlx5: add e-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 20:32 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-12 20:01 ` [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-14 12:57 ` Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 3/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 4/4] net/mlx5: add E-switch rule hardware offload flag check Slava Ovsiienko 2018-11-13 13:21 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Shahaf Shuler 2018-11-14 14:56 ` Shahaf Shuler 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-04 6:48 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Shahaf Shuler 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-02 21:38 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-02 21:53 ` Yongseok Koh 2018-11-02 23:29 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181101203615.GE6118@mtidpdk.mti.labs.mlnx \ --to=yskoh@mellanox.com \ --cc=dev@dpdk.org \ --cc=shahafs@mellanox.com \ --cc=viacheslavo@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git