From: Yongseok Koh <yskoh@mellanox.com> To: Slava Ovsiienko <viacheslavo@mellanox.com> Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v3 09/13] net/mlx5: e-switch VXLAN netlink routines update Date: Thu, 1 Nov 2018 21:21:56 +0000 Message-ID: <20181101212101.GJ6118@mtidpdk.mti.labs.mlnx> (raw) In-Reply-To: <1541074741-41368-10-git-send-email-viacheslavo@mellanox.com> On Thu, Nov 01, 2018 at 05:19:31AM -0700, Slava Ovsiienko wrote: > This part of patchset updates Netlink exchange routine. Message > sequence numbers became not random ones, the multipart reply messages > are supported, not propagating errors to the following socket calls, > Netlink replies buffer size is increased to MNL_SOCKET_BUFFER_SIZE > and now is preallocated at context creation time instead of stack > usage. This update is needed to support Netlink query operations. > > Suggested-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> > --- I have acked this patch in v2. If this patch is changed since v2, you can drop my acked-by tag but if there's no change, please preserve the tag. Just FYI :-) Acked-by: Yongseok Koh <yskoh@mellanox.com> Thanks > drivers/net/mlx5/mlx5_flow_tcf.c | 83 +++++++++++++++++++++++++++++----------- > 1 file changed, 61 insertions(+), 22 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c > index c404a63..67a6ff3 100644 > --- a/drivers/net/mlx5/mlx5_flow_tcf.c > +++ b/drivers/net/mlx5/mlx5_flow_tcf.c > @@ -3678,37 +3678,76 @@ struct pedit_parser { > /** > * Send Netlink message with acknowledgment. > * > - * @param ctx > + * @param tcf > * Flow context to use. > * @param nlh > * Message to send. This function always raises the NLM_F_ACK flag before > * sending. > + * @param[in] msglen > + * Message length. Message buffer may contain multiple commands and > + * nlmsg_len field not always corresponds to actual message length. > + * If 0 specified the nlmsg_len field in header is used as message length. > + * @param[in] cb > + * Callback handler for received message. > + * @param[in] arg > + * Context pointer for callback handler. > * > * @return > * 0 on success, a negative errno value otherwise and rte_errno is set. > */ > static int > -flow_tcf_nl_ack(struct mlx5_flow_tcf_context *ctx, struct nlmsghdr *nlh) > +flow_tcf_nl_ack(struct mlx5_flow_tcf_context *tcf, > + struct nlmsghdr *nlh, > + uint32_t msglen, > + mnl_cb_t cb, void *arg) > { > - alignas(struct nlmsghdr) > - uint8_t ans[mnl_nlmsg_size(sizeof(struct nlmsgerr)) + > - nlh->nlmsg_len - sizeof(*nlh)]; > - uint32_t seq = ctx->seq++; > - struct mnl_socket *nl = ctx->nl; > - int ret; > - > - nlh->nlmsg_flags |= NLM_F_ACK; > + unsigned int portid = mnl_socket_get_portid(tcf->nl); > + uint32_t seq = tcf->seq++; > + int err, ret; > + > + assert(tcf->nl); > + assert(tcf->buf); > + if (!seq) > + /* seq 0 is reserved for kernel event-driven notifications. */ > + seq = tcf->seq++; > nlh->nlmsg_seq = seq; > - ret = mnl_socket_sendto(nl, nlh, nlh->nlmsg_len); > - if (ret != -1) > - ret = mnl_socket_recvfrom(nl, ans, sizeof(ans)); > - if (ret != -1) > - ret = mnl_cb_run > - (ans, ret, seq, mnl_socket_get_portid(nl), NULL, NULL); > + if (!msglen) { > + msglen = nlh->nlmsg_len; > + nlh->nlmsg_flags |= NLM_F_ACK; > + } > + ret = mnl_socket_sendto(tcf->nl, nlh, msglen); > + err = (ret <= 0) ? errno : 0; > + nlh = (struct nlmsghdr *)(tcf->buf); > + /* > + * The following loop postpones non-fatal errors until multipart > + * messages are complete. > + */ > if (ret > 0) > + while (true) { > + ret = mnl_socket_recvfrom(tcf->nl, tcf->buf, > + tcf->buf_size); > + if (ret < 0) { > + err = errno; > + if (err != ENOSPC) > + break; > + } > + if (!err) { > + ret = mnl_cb_run(nlh, ret, seq, portid, > + cb, arg); > + if (ret < 0) { > + err = errno; > + break; > + } > + } > + /* Will receive till end of multipart message */ > + if (!(nlh->nlmsg_flags & NLM_F_MULTI) || > + nlh->nlmsg_type == NLMSG_DONE) > + break; > + } > + if (!err) > return 0; > - rte_errno = errno; > - return -rte_errno; > + rte_errno = err; > + return -err; > } > > /** > @@ -3739,7 +3778,7 @@ struct pedit_parser { > nlh = dev_flow->tcf.nlh; > nlh->nlmsg_type = RTM_NEWTFILTER; > nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_CREATE | NLM_F_EXCL; > - if (!flow_tcf_nl_ack(ctx, nlh)) > + if (!flow_tcf_nl_ack(ctx, nlh, 0, NULL, NULL)) > return 0; > return rte_flow_error_set(error, rte_errno, > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > @@ -3778,7 +3817,7 @@ struct pedit_parser { > nlh = dev_flow->tcf.nlh; > nlh->nlmsg_type = RTM_DELTFILTER; > nlh->nlmsg_flags = NLM_F_REQUEST; > - flow_tcf_nl_ack(ctx, nlh); > + flow_tcf_nl_ack(ctx, nlh, 0, NULL, NULL); > } > > /** > @@ -4311,7 +4350,7 @@ struct pedit_parser { > tcm->tcm_handle = TC_H_MAKE(TC_H_INGRESS, 0); > tcm->tcm_parent = TC_H_INGRESS; > /* Ignore errors when qdisc is already absent. */ > - if (flow_tcf_nl_ack(ctx, nlh) && > + if (flow_tcf_nl_ack(ctx, nlh, 0, NULL, NULL) && > rte_errno != EINVAL && rte_errno != ENOENT) > return rte_flow_error_set(error, rte_errno, > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > @@ -4327,7 +4366,7 @@ struct pedit_parser { > tcm->tcm_handle = TC_H_MAKE(TC_H_INGRESS, 0); > tcm->tcm_parent = TC_H_INGRESS; > mnl_attr_put_strz_check(nlh, sizeof(buf), TCA_KIND, "ingress"); > - if (flow_tcf_nl_ack(ctx, nlh)) > + if (flow_tcf_nl_ack(ctx, nlh, 0, NULL, NULL)) > return rte_flow_error_set(error, rte_errno, > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > "netlink: failed to create ingress" > -- > 1.8.3.1 >
next prev parent reply other threads:[~2018-11-01 21:21 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 6:30 [dpdk-dev] [PATCH 1/5] net/mlx5: add VXLAN encap/decap support for e-switch Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 2/5] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 3/5] net/mlx5: e-switch VXLAN flow validation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 4/5] net/mlx5: e-switch VXLAN flow translation routine Slava Ovsiienko 2018-10-02 6:30 ` [dpdk-dev] [PATCH 5/5] net/mlx5: e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 0/7] net/mlx5: e-switch VXLAN encap/decap hardware offload Viacheslav Ovsiienko 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions Viacheslav Ovsiienko 2018-10-23 10:01 ` Yongseok Koh 2018-10-25 12:50 ` Slava Ovsiienko 2018-10-25 23:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine Viacheslav Ovsiienko 2018-10-23 10:04 ` Yongseok Koh 2018-10-25 13:53 ` Slava Ovsiienko 2018-10-26 3:07 ` Yongseok Koh 2018-10-26 8:39 ` Slava Ovsiienko 2018-10-26 21:56 ` Yongseok Koh 2018-10-29 9:33 ` Slava Ovsiienko 2018-10-29 18:26 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine Viacheslav Ovsiienko 2018-10-23 10:06 ` Yongseok Koh 2018-10-25 14:37 ` Slava Ovsiienko 2018-10-26 4:22 ` Yongseok Koh 2018-10-26 9:06 ` Slava Ovsiienko 2018-10-26 22:10 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 4/7] net/mlx5: e-switch VXLAN netlink routines update Viacheslav Ovsiienko 2018-10-23 10:07 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management Viacheslav Ovsiienko 2018-10-25 0:28 ` Yongseok Koh 2018-10-25 20:21 ` Slava Ovsiienko 2018-10-26 6:25 ` Yongseok Koh 2018-10-26 9:35 ` Slava Ovsiienko 2018-10-26 22:42 ` Yongseok Koh 2018-10-29 11:53 ` Slava Ovsiienko 2018-10-29 18:42 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 6/7] net/mlx5: e-switch VXLAN encapsulation rules management Viacheslav Ovsiienko 2018-10-25 0:33 ` Yongseok Koh 2018-10-15 14:13 ` [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines Viacheslav Ovsiienko 2018-10-25 0:36 ` Yongseok Koh 2018-10-25 20:32 ` Slava Ovsiienko 2018-10-26 6:30 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 01/13] net/mlx5: prepare makefile for adding e-switch VXLAN Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 02/13] net/mlx5: prepare meson.build " Slava Ovsiienko 2018-11-01 20:33 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-01 20:35 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-01 20:36 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 05/13] net/mlx5: swap items/actions validations for e-switch rules Slava Ovsiienko 2018-11-01 20:37 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 06/13] net/mlx5: add e-switch VXLAN support to validation routine Slava Ovsiienko 2018-11-01 20:49 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-01 21:03 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-01 21:18 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 09/13] net/mlx5: e-switch VXLAN netlink routines update Slava Ovsiienko 2018-11-01 21:21 ` Yongseok Koh [this message] 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 10/13] net/mlx5: fix e-switch Flow counter deletion Slava Ovsiienko 2018-11-01 22:00 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 11/13] net/mlx5: add e-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-01 23:59 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 12/13] net/mlx5: add e-switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 12:19 ` [dpdk-dev] [PATCH v3 13/13] net/mlx5: add e-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-02 0:01 ` Yongseok Koh 2018-11-01 20:32 ` [dpdk-dev] [PATCH v3 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 1/4] net/mlx5: prepare Netlink communication routine to fix Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-12 20:01 ` [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine Slava Ovsiienko 2018-11-13 13:21 ` Shahaf Shuler 2018-11-14 12:57 ` Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 3/4] net/mlx5: prepare to add E-switch rule flags check Slava Ovsiienko 2018-11-12 20:01 ` [dpdk-dev] [PATCH 4/4] net/mlx5: add E-switch rule hardware offload flag check Slava Ovsiienko 2018-11-13 13:21 ` [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Shahaf Shuler 2018-11-14 14:56 ` Shahaf Shuler 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-03 6:18 ` [dpdk-dev] [PATCH v5 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko 2018-11-04 6:48 ` [dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload Shahaf Shuler 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 03/13] net/mlx5: add necessary definitions for " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 04/13] net/mlx5: add necessary structures " Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 05/13] net/mlx5: swap items/actions validations for E-Switch rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 07/13] net/mlx5: add VXLAN support to flow prepare routine Slava Ovsiienko 2018-11-02 21:38 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 06/13] net/mlx5: add E-Switch VXLAN support to validation routine Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine Slava Ovsiienko 2018-11-02 21:53 ` Yongseok Koh 2018-11-02 23:29 ` Yongseok Koh 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 09/13] net/mlx5: update E-Switch VXLAN netlink routines Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 10/13] net/mlx5: fix E-Switch Flow counter deletion Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 11/13] net/mlx5: add E-switch VXLAN tunnel devices management Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules Slava Ovsiienko 2018-11-02 17:53 ` [dpdk-dev] [PATCH v4 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines Slava Ovsiienko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181101212101.GJ6118@mtidpdk.mti.labs.mlnx \ --to=yskoh@mellanox.com \ --cc=dev@dpdk.org \ --cc=shahafs@mellanox.com \ --cc=viacheslavo@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git