From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B97301B1F6 for ; Fri, 2 Nov 2018 12:25:13 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2018 04:25:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,455,1534834800"; d="scan'208";a="86178266" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga007.jf.intel.com with SMTP; 02 Nov 2018 04:25:09 -0700 Received: by (sSMTP sendmail emulation); Fri, 02 Nov 2018 11:25:08 +0000 Date: Fri, 2 Nov 2018 11:25:08 +0000 From: Bruce Richardson To: Honnappa Nagarahalli Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org, gavin.hu@arm.com, dharmik.thakkar@arm.com, nd@arm.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com Message-ID: <20181102112507.GE26868@bricha3-MOBL.ger.corp.intel.com> References: <20181101045454.632-2-honnappa.nagarahalli@arm.com> <20181101232522.702-1-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181101232522.702-1-honnappa.nagarahalli@arm.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 11:25:14 -0000 On Thu, Nov 01, 2018 at 06:25:18PM -0500, Honnappa Nagarahalli wrote: > Various configuration flags in rte_hash library result in increase of > number of test cases. Configuration flags for enabling transactional > memory use and read/write concurrency are not required. These features > should be supported by default. Please refer to [1] for more context. > > This patch marks these flags for deprecation in 19.02 release and cleans > up the test cases. > > [1] http://mails.dpdk.org/archives/dev/2018-October/117268.html > > Honnappa Nagarahalli (4): hash: prepare for deprecation of flags hash: > deprecate lock ellision and read/write concurreny flags test/hash: stop > using lock ellision and read/write concurreny flags doc/hash: deprecate > lock ellision and read/write concurreny flags > While I'd like to reduce the flags and do cleanup, I'm a little concerned about putting this scope of changes in so late in the release. I wonder if less drastic changes could work as well for this release, and do the cleanup later. For example, rather than deprecating the flags now, how about just change the default for when no flags are set? If user has set flags, follow the existing path - if flags is set to zero, then have the defaults be to use RW concurrency or TSX. /Bruce