From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Yipeng Wang <yipeng1.wang@intel.com>, stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH 1/4] hash: fix TSX aborts with newer gcc Date: Mon, 5 Nov 2018 17:39:10 +0000 Message-ID: <20181105173913.61225-2-bruce.richardson@intel.com> (raw) In-Reply-To: <20181105173913.61225-1-bruce.richardson@intel.com> From: Yipeng Wang <yipeng1.wang@intel.com> gcc 7 and 8 with O3 will generate vzeroupper from rte_memcpy into TSX region which may abort the TSX transaction. This fix changes rte_memcpy to memcpy which will not insert extra vzeroupper into the library. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: stable@dpdk.org Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- lib/librte_hash/rte_cmp_x86.h | 2 ++ lib/librte_hash/rte_cuckoo_hash.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_hash/rte_cmp_x86.h b/lib/librte_hash/rte_cmp_x86.h index e82b4c0..13a5836 100644 --- a/lib/librte_hash/rte_cmp_x86.h +++ b/lib/librte_hash/rte_cmp_x86.h @@ -2,6 +2,8 @@ * Copyright(c) 2015 Intel Corporation */ +#include <rte_vect.h> + /* Functions to compare multiple of 16 byte keys (up to 128 bytes) */ static int rte_hash_k16_cmp_eq(const void *key1, const void *key2, size_t key_len __rte_unused) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 5ddcccd..76f5dc8 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -13,7 +13,6 @@ #include <rte_common.h> #include <rte_memory.h> /* for definition of RTE_CACHE_LINE_SIZE */ #include <rte_log.h> -#include <rte_memcpy.h> #include <rte_prefetch.h> #include <rte_branch_prediction.h> #include <rte_malloc.h> @@ -982,7 +981,7 @@ struct rte_hash * new_k = RTE_PTR_ADD(keys, (uintptr_t)slot_id * h->key_entry_size); new_idx = (uint32_t)((uintptr_t) slot_id); /* Copy key */ - rte_memcpy(new_k->key, key, h->key_len); + memcpy(new_k->key, key, h->key_len); /* Key can be of arbitrary length, so it is not possible to store * it atomically. Hence the new key element's memory stores * (key as well as data) should be complete before it is referenced. -- 1.8.5.6
next prev parent reply other threads:[~2018-11-05 17:39 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-05 17:39 [dpdk-dev] [PATCH 0/4] fixes for rte_hash with TSX Bruce Richardson 2018-11-05 17:39 ` Bruce Richardson [this message] 2018-11-05 17:39 ` [dpdk-dev] [PATCH 2/4] hash: add local cache for TSX region Bruce Richardson 2018-11-09 15:59 ` Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson 2018-11-05 17:39 ` [dpdk-dev] [PATCH 4/4] test/test: improve output for hash read-write test Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 1/4] hash: fix TSX aborts with newer gcc Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 2/4] hash: add local cache for TSX region Bruce Richardson 2018-11-12 18:34 ` Honnappa Nagarahalli 2018-11-13 16:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2018-11-13 17:16 ` Honnappa Nagarahalli 2018-11-13 17:24 ` Wang, Yipeng1 2018-11-13 17:48 ` Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 3/4] eal/x86: reduce contention when retrying TSX Bruce Richardson 2018-11-12 10:47 ` [dpdk-dev] [PATCH v2 4/4] test/test: improve output for hash read-write test Bruce Richardson 2018-11-14 0:06 ` [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181105173913.61225-2-bruce.richardson@intel.com \ --to=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ --cc=yipeng1.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git