From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 9B1A131FC for ; Tue, 6 Nov 2018 22:49:08 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id p6-v6so6829509pll.4 for ; Tue, 06 Nov 2018 13:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LrF2QpZBWl61wAdEzVTvopVPOQsXeHpnnpeEgQEx8i8=; b=HRjwC/MnUVlvqAB5yyGt/z+QouWsc0SaNjFyrlPklNFsCjpp9nCVDVkllMfy0CAhsF xGfdefxGsApBw+5J2eFuqdfYYOLo3iQEc/v896FdkV6YY9puwQNQO9yQ/xrh9O3ekn4Y GIncGitUHDPNOOxTdFROXEN4yU3UfrI4jslQpnGrE2K0bwJY6+X6QPAutki5OFt274mo LQcKmzUHkIxLpSvC6wYCJiPbx/QUtW/E5SOtQxPLkl0d3VwJr00GzqDi4eihfzJfBPWv SkqtP4AQ+oHD6wYt+T4Fvg3JUxHSjvil+nN2yqPJCWGxK/Kb3p16Lh0lomrd77aISOMM tWNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LrF2QpZBWl61wAdEzVTvopVPOQsXeHpnnpeEgQEx8i8=; b=d5/aX+NUyu3NBH0i6jXbFhEkU8iKvHRtpmpbCxtbVHiR5P0kYmzhGfR9cbHLYQ/sD9 u7M5YDx7lAq1C0ABhKz5eBp4cjVH4aaQ2YDCelXNeFZcCsTHQhNEpiHhy2Z9bw40oZtg iZ6JCol0d6zvmFmpTYPObEvN/FkaXkzK+3urxla+N3n0SCZqTNwI/6S+tv4w71s2sDkW 2dIDuEQrumCq2yvFno0uP8lgEl4Xt1E+zIyOZy1RE0MgBow7zPTxxLbOnpETfI9R71Mg 1mmVw3kFcW10j8ai888zG7OnwdaDrZnP9V/vuCgHofFvWly28drEYju6nr4pH04/O4FC 9ljw== X-Gm-Message-State: AGRZ1gLgqGKOsQ298ypgcG23dpsKdpcMBk/WrpPSDHxnCUViOP1qy4vK KoXsb/F0DTYl09C1N7A4erYztR5rmnU= X-Google-Smtp-Source: AJdET5dHDcBHP7IMQ8pFWa1fwf+yo0JJWJXkcHGe0AaOMVQBGpuxbIINU4mQPepfBq/QZ9QOsGefCA== X-Received: by 2002:a17:902:7c94:: with SMTP id y20-v6mr27948742pll.218.1541540947273; Tue, 06 Nov 2018 13:49:07 -0800 (PST) Received: from localhost.localdomain ([167.220.103.1]) by smtp.gmail.com with ESMTPSA id y1sm5653608pfi.123.2018.11.06.13.49.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 13:49:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 6 Nov 2018 13:49:00 -0800 Message-Id: <20181106214901.1392-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106214901.1392-1-stephen@networkplumber.org> References: <20181106214901.1392-1-stephen@networkplumber.org> Subject: [dpdk-dev] [RFC 4/5] eal/memory: avoid double munmap in error path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 21:49:09 -0000 Don't call munmap of hugepage memory twice in the error path. Coverity issue: 325730 Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index c1b5e079117a..48b23ce19ad3 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1617,6 +1617,7 @@ eal_legacy_hugepage_init(void) tmp_hp = NULL; munmap(hugepage, nr_hugefiles * sizeof(struct hugepage_file)); + hugepage = NULL; /* we're not going to allocate more pages, so release VA space for * unused memseg lists -- 2.17.1