From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id E81062B94 for ; Wed, 7 Nov 2018 10:54:19 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id w7-v6so13326670wmc.1 for ; Wed, 07 Nov 2018 01:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FsvUy6CXcxFVCZvELKZNVzI32823QUkC4d0mCDjT+4o=; b=ZGfWoALX+xPXI1THvBkawEUEIVly3m5Z3gacJ1l3qTyFC69zUttcQF4sQl5P9oFQtA 0Y7BQKO6Oa2yxso0ttTsDVCwkpS56hRodVNt71sm2IzY1G7AfSfBoZstgxqVIfvF1zJi X8mcCk3w6BqXjfWoBe9N2T3xaoZz9m3u0D8Rl5FR14+mqq5O/w6qMT24Nohy3HIbSAQ0 3FXVn92b/nNXuDDngjiFSuNSOelx40c2BfjI57fobQee22kSdwR66WBD4YrALYT62Jur yxFBy3ifSLI1aUzimMGObX6zbTIQUpIq5cSGii7tlXpPJgCoZ3Sa7J6bCNhv4Up2NcqD wnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FsvUy6CXcxFVCZvELKZNVzI32823QUkC4d0mCDjT+4o=; b=UCYD5WnT+fK9uBf1tBLCTHgMvRDp8uZGnQU9GOw3BmVzsG7bllimSL9LxWcUEyeTRu FQUEQa9TtD6rk9rTEhTbLbltPphJyRBpCAxa6cbRrirU8bd82ZXYYZ7hUNMZvFNjcP/a f7Q6Oi/DTJnlfrREAFx4IjGkpK13k78AKX7CpZbgA+CcFlBn2GmI4LAl1GbvEGHnI2Jz eIs/70/4uzoPDvvv3uSIBZ/CA2W56udiMtbOlupSndsqKW388xzcXQnB4UronP39Mej+ vbm4cd3aYnd5HuDs1lxoIzn54Ely0nyKCAHdK3NL5GcjnCgjtJARgiFzMHNSnWn4eB/b RStw== X-Gm-Message-State: AGRZ1gIG76tff2R9EZdD29S+LYrQvT+fwfLg3jwD2Zw0zYomid96l/He kQi/Sj44n79Uk7E5jzeVq4r5fA== X-Google-Smtp-Source: AJdET5cG9V/LcEgHj4Y6cn4XnRMvWg/kOyZoMMdB3jDvrCTY8n3+V+2uM4dphLrxxQH5nbyEloF5Lw== X-Received: by 2002:a1c:c142:: with SMTP id r63-v6mr1365345wmf.95.1541584459654; Wed, 07 Nov 2018 01:54:19 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g5-v6sm780961wmf.34.2018.11.07.01.54.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Nov 2018 01:54:18 -0800 (PST) Date: Wed, 7 Nov 2018 10:54:00 +0100 From: Adrien Mazarguil To: "Peng, Yuan" Cc: "Zhao1, Wei" , "dev@dpdk.org" Message-ID: <20181107095400.GI4638@6wind.com> References: <67D543A150B29E4CAAE53918F64EDAEA37627F5A@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67D543A150B29E4CAAE53918F64EDAEA37627F5A@SHSMSX103.ccr.corp.intel.com> Subject: Re: [dpdk-dev] a doubt about rss types action in rte_flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 09:54:20 -0000 Hi and sorry for the delay. On Thu, Oct 18, 2018 at 06:42:52AM +0000, Peng, Yuan wrote: > Hi Adrien, > > I have a doubt about the action rss types in rte_flow. > testpmd> flow create 0 ingress pattern end actions rss types end / end > > what is the expected function of the command? > Does it mean enable RSS in no types? So actually it can disable rss all? Doing so requests whatever counts as default RSS from the driver as documented in doc/guides/prog_guide/rte_flow.rst: "Unlike global RSS settings used by other DPDK APIs, unsetting the ``types`` field does not disable RSS in a flow rule. Doing so instead requests safe unspecified "best-effort" settings from the underlying PMD, which depending on the flow rule, may result in anything ranging from empty (single queue) to all-inclusive RSS." > There are different execution result of the command from our different NICs. > Some NICs report error: > Caught error type 2 (flow rule (handle)): Failed to create flow.: Invalid argument > With some NICs, the command can be executed successfully, and disable rss function for all packet types. > > Could you help to solve my questions? PMDs must handle it as described by the documentation, 0 being the only safe value applications can rely on regardless of device properties; applications that just want traffic to be spread somehow among the queues they configured instead of a single queue. Therefore PMDs that currently reject it should be fixed. -- Adrien Mazarguil 6WIND