From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id 0F56A4C94; Fri, 9 Nov 2018 09:20:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xHn1M1CnNshYLU5ONpTrsfP2ZyqYUz72o5KbrRhpCM=; b=oAGHaPHKic193zgTBRB9KN5ZxdXxVPiO9fOCoV0e9FBFfDAroBMcXrzdoY8F7L5tg0eGSYAiH3qiSPzOipqvAOI4ON0TRD/WU0lNSF6YFwNzOHiWgcoeL2dBz8Mfu7Vo4c7XrLYj8+S1CxBFbWXaSIs8wBgcWiHzQzQQL1M7aqo= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5064.namprd07.prod.outlook.com (52.135.239.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Fri, 9 Nov 2018 08:20:15 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%3]) with mapi id 15.20.1294.034; Fri, 9 Nov 2018 08:20:15 +0000 From: Jerin Jacob To: "Dabilpuram, Nithin" CC: "dev@dpdk.org" , "Jacob, Jerin" , "Czekaj, Maciej" , "Nilla, Subrahmanyam" , "stable@dpdk.org" Thread-Topic: [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode Thread-Index: AQHUd/AuSS2AzzKAgEaWUfJgiWHgWqVHGiUA Date: Fri, 9 Nov 2018 08:20:15 +0000 Message-ID: <20181109082000.GA4934@jerin> References: <1541742633-798-1-git-send-email-nithin.dabilpuram@caviumnetworks.com> In-Reply-To: <1541742633-798-1-git-send-email-nithin.dabilpuram@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::20) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5064; 6:QYOLf+PQdnP4UYmcJQRa3BOizbzBk3eqVqT/2tdmdZrgtBvbOBiQZM/1yQb29jb69ghfbxHjSFbGjW5VkAVHr1W8eMtllI/ktAZ0T55GUbf14kTkEbjACq0cbMzE1xS5IHKTy1vM2xy30rB6DkxgI+0GuhebDk/C72dIuMSihAFL0LNnV2K3JZI2KsdeHVSn1zy91nlqRZVKhYmON7MUH6tQsHEoQTmrJf8Dr7F65Of60auSnl61Kr3RS2bgob4EaWU3rmhgmNJbJB1jIummIOttw3/O9hSGotEawfUPhkk6nhEEkwkY3PxHeEQy61NHTClVujeqSC8JP4nx72YUUjjBEf5r5FSfKqgofVU5+VViLWrd5eOkWJuc4Rhfaf6/IMhHeiVyWmTkgvXIJJqLHxVGHbn47yK+Kq6GfRaBBxxHYg2uhd9Vz78cncDEHAa46HOLQ1/syr0TeQiKFtY2sA==; 5:f9RradRNbi7DHfc5y1mCV91frn+9L/c5P3yLmdRVUuiA0trVdAne41KC0aGV2dpa0KsxBVCppSMhs0lYukGIEVNGO4MHOmpR1vFYsHHYKfliAzHgGA98oi1z5kES+/jETmvdMA4+xH0wXZPJ4TFn13P5mf3OgLdo/ccKgdK6qMY=; 7:Mpou1TGXawSL3ZDZgaVuP40PrwUnLJkj5BZY2h7+DEg5ugBEqfesl9e8mLMl5yAy3MOj0xtU6FXBsNwz1ksDBmho30CassanVX+jTuX26jgvgIvHCbEgruY6LyIIMVwsB+OLdXU+WkYZyGz2AoLKlg== x-ms-office365-filtering-correlation-id: b7d74be3-48ac-4bba-5e31-08d6461c2cd7 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5064; x-ms-traffictypediagnostic: BYAPR07MB5064: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5064; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5064; x-forefront-prvs: 08512C5403 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(376002)(366004)(136003)(346002)(39860400002)(396003)(13464003)(199004)(189003)(478600001)(5660300001)(186003)(33896004)(25786009)(52116002)(99286004)(106356001)(105586002)(7736002)(72206003)(68736007)(102836004)(386003)(6506007)(33716001)(6486002)(305945005)(33656002)(6436002)(55236004)(256004)(26005)(11346002)(1076002)(42882007)(71200400001)(76176011)(54906003)(6246003)(4326008)(450100002)(229853002)(71190400001)(6512007)(6116002)(81166006)(8936002)(81156014)(446003)(316002)(3846002)(9686003)(476003)(486006)(66066001)(14454004)(2900100001)(6862004)(97736004)(53936002)(2906002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5064; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mm5uxNzNnH95TZVkhzxOlY0A78uoyXLmrrRTkdZYnhK4qupAWEZK0qxYMnR9GnOcPJqCFsh/XTTEc6YUSBhZU41lv51AjnJ9ypM6z2ty3iELIw9viKLZaOMSHh7o33DCfqSzlAqBnGvDbT3TLBKkSdA10LmBDrZD34iP2FLj0NqEONRgkPJFiaLmD3yddX0e2uqIesxqeU4ZzH6R5kH8PBQX2X99HjXb9uL9UPwJfPdanjzU0BsEFqx1/B7fVrYCH5zGsT6UTE0oujda0K3q4Z1EcTCI6PiKQUr36Vyxs5gNPgvQ2c51uqmU++MV5RH5XVuK1ySrxnMXiv9GnMrdmhE/yXItm966aJ//XNrDJeQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <2FF7BDA79F5E0442B828618F2352B36E@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7d74be3-48ac-4bba-5e31-08d6461c2cd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2018 08:20:15.0357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5064 Subject: Re: [dpdk-dev] [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 08:20:17 -0000 -----Original Message----- > Date: Fri, 9 Nov 2018 11:20:55 +0530 > From: "Dabilpuram, Nithin" > To: "dev@dpdk.org" , "Jacob, Jerin" > , "Czekaj, Maciej" > > CC: "Nilla, Subrahmanyam" , > "stable@dpdk.org" , "Dabilpuram, Nithin" > > Subject: [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather > mode >=20 > From: Subrahmanyam Nilla >=20 > For performance reasons, word1 of send_hdr_s > sub descriptor was not cleared assuming it is always > having default value of zero since it comes from fixed > offsets of SQ buffer. > This is causing issues in case of SG mode because, > the size of send command might change and hence the word1 > of send_hdr_s is not always at fixed offsets of the SQ buffer > and hence not having default value of zero. >=20 > This fixes the issue by clearing the word1 in case of SG mode > for every packet. >=20 > Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Subrahmanyam Nilla > Signed-off-by: Nithin Dabilpuram > --- Acked-by: Jerin Jacob