DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: deprecation notice for sched API change
@ 2018-11-14 15:36 Jasvinder Singh
  2018-11-16 16:10 ` Pattan, Reshma
  2018-11-21  9:39 ` Mohammad Abdul Awal
  0 siblings, 2 replies; 4+ messages in thread
From: Jasvinder Singh @ 2018-11-14 15:36 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu

There will be change in API functions because of mbuf sched field
updates, outlined in deprecation note of mbuf->hash.sched.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 34b28234c..b54598d07 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -34,6 +34,11 @@ Deprecation Notices
   is defined in librte_sched in a non-generic way. The new generic format
   will contain: queue ID, traffic class, color. Field size will not change.
 
+* sched: Some API functions will change prototype due to the above
+  deprecation note for mbuf->hash.sched, e.g. rte_sched_port_pkt_write() and
+  rte_sched_port_pkt_read() will likely have an additional parameter
+  of type struct rte_sched_port.
+
 * mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or later and
   replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. As
   ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, ``RTE_MBUF_INDIRECT()``
-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change
  2018-11-14 15:36 [dpdk-dev] [PATCH] doc: deprecation notice for sched API change Jasvinder Singh
@ 2018-11-16 16:10 ` Pattan, Reshma
  2018-11-21  9:39 ` Mohammad Abdul Awal
  1 sibling, 0 replies; 4+ messages in thread
From: Pattan, Reshma @ 2018-11-16 16:10 UTC (permalink / raw)
  To: Singh, Jasvinder, dev; +Cc: Dumitrescu, Cristian



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, November 14, 2018 3:37 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change
> 
> There will be change in API functions because of mbuf sched field updates,
> outlined in deprecation note of mbuf->hash.sched.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change
  2018-11-14 15:36 [dpdk-dev] [PATCH] doc: deprecation notice for sched API change Jasvinder Singh
  2018-11-16 16:10 ` Pattan, Reshma
@ 2018-11-21  9:39 ` Mohammad Abdul Awal
  2018-11-24 18:13   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Mohammad Abdul Awal @ 2018-11-21  9:39 UTC (permalink / raw)
  To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu



On 14/11/2018 15:36, Jasvinder Singh wrote:
> There will be change in API functions because of mbuf sched field
> updates, outlined in deprecation note of mbuf->hash.sched.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 34b28234c..b54598d07 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -34,6 +34,11 @@ Deprecation Notices
>     is defined in librte_sched in a non-generic way. The new generic format
>     will contain: queue ID, traffic class, color. Field size will not change.
>   
> +* sched: Some API functions will change prototype due to the above
> +  deprecation note for mbuf->hash.sched, e.g. rte_sched_port_pkt_write() and
> +  rte_sched_port_pkt_read() will likely have an additional parameter
> +  of type struct rte_sched_port.
> +
>   * mbuf: the macro ``RTE_MBUF_INDIRECT()`` will be removed in v18.08 or later and
>     replaced with ``RTE_MBUF_CLONED()`` which is already added in v18.05. As
>     ``EXT_ATTACHED_MBUF`` is newly introduced in v18.05, ``RTE_MBUF_INDIRECT()``
Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change
  2018-11-21  9:39 ` Mohammad Abdul Awal
@ 2018-11-24 18:13   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-11-24 18:13 UTC (permalink / raw)
  To: Jasvinder Singh; +Cc: dev, Mohammad Abdul Awal, cristian.dumitrescu

21/11/2018 10:39, Mohammad Abdul Awal:
> On 14/11/2018 15:36, Jasvinder Singh wrote:
> > There will be change in API functions because of mbuf sched field
> > updates, outlined in deprecation note of mbuf->hash.sched.
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-24 18:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 15:36 [dpdk-dev] [PATCH] doc: deprecation notice for sched API change Jasvinder Singh
2018-11-16 16:10 ` Pattan, Reshma
2018-11-21  9:39 ` Mohammad Abdul Awal
2018-11-24 18:13   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git