DPDK patches and discussions
 help / color / mirror / Atom feed
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Luca Boccassi <bluca@debian.org>, dev <dev@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: [dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson)
Date: Wed, 14 Nov 2018 20:40:11 +0100	[thread overview]
Message-ID: <20181114194012.18255-1-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20181114143315.2695-1-christian.ehrhardt@canonical.com>

So far only if machine was "native" it did use the re-direction to
not set -march on ppc64 (where -march is not supported).
We have to use mcpu/mtune in any case on ppc for whatever someone using
the build system defines as machine.

Fixes: 54d609a13876 ("build: add ppc64 meson build")

Acked-by: Luca Boccassi <bluca@debian.org>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 config/meson.build | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 0b710b795..1af305f46 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -9,8 +9,9 @@ else
 endif
 dpdk_conf.set('RTE_MACHINE', machine)
 machine_args = []
-# ppc64 does not support -march=native
-if host_machine.cpu_family().startswith('ppc') and machine == 'native'
+
+# ppc64 does not support -march= at all, use -mcpu and -mtune for that
+if host_machine.cpu_family().startswith('ppc')
 	machine_args += '-mcpu=' + machine
 	machine_args += '-mtune=' + machine
 else
-- 
2.17.1

  parent reply	other threads:[~2018-11-14 19:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 11:34 [dpdk-dev] [PATCH " Christian Ehrhardt
2018-11-14 11:34 ` [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type Christian Ehrhardt
2018-11-14 11:40   ` Luca Boccassi
2018-11-14 11:52     ` Bruce Richardson
2018-11-14 12:05       ` Luca Boccassi
2018-11-14 13:09         ` Christian Ehrhardt
2018-11-14 13:18           ` [dpdk-dev] [PATCH] " Christian Ehrhardt
2018-11-14 13:54             ` Bruce Richardson
2018-11-14 14:33               ` [dpdk-dev] [PATCH v3] " Christian Ehrhardt
2018-11-14 19:39                 ` Christian Ehrhardt
2018-11-18 13:24                   ` Thomas Monjalon
2018-11-14 19:40                 ` Christian Ehrhardt [this message]
2018-11-14 19:40                   ` [dpdk-dev] [PATCH v4 2/2] " Christian Ehrhardt
2018-11-18 14:24                   ` [dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson) Thomas Monjalon
2018-11-14 13:06   ` [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type Luca Boccassi
2018-11-14 13:08     ` Christian Ehrhardt
2018-11-14 11:39 ` [dpdk-dev] [PATCH 1/2] build: avoid non supported -march on ppc (meson) Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181114194012.18255-1-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).