* [dpdk-dev] [PATCH] net/mlx5: fix flow destruction
@ 2018-11-15 5:24 Yongseok Koh
2018-11-15 8:50 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-11-15 5:24 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev, Yongseok Koh, Ori Kam
As flow_drv_destroy() frees dev_flow, flow_rxq_flags_trim() must be called
ahead.
Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
Cc: orika@mellanox.com
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 5ad3a11ab7..01499c462a 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2127,14 +2127,14 @@ static void
flow_list_destroy(struct rte_eth_dev *dev, struct mlx5_flows *list,
struct rte_flow *flow)
{
- flow_drv_destroy(dev, flow);
- TAILQ_REMOVE(list, flow, next);
/*
* Update RX queue flags only if port is started, otherwise it is
* already clean.
*/
if (dev->data->dev_started)
flow_rxq_flags_trim(dev, flow);
+ flow_drv_destroy(dev, flow);
+ TAILQ_REMOVE(list, flow, next);
rte_free(flow->fdir);
rte_free(flow);
}
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow destruction
2018-11-15 5:24 [dpdk-dev] [PATCH] net/mlx5: fix flow destruction Yongseok Koh
@ 2018-11-15 8:50 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-11-15 8:50 UTC (permalink / raw)
To: Yongseok Koh; +Cc: dev, Ori Kam
Thursday, November 15, 2018 7:24 AM, Yongseok Koh:
> <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix flow destruction
>
> As flow_drv_destroy() frees dev_flow, flow_rxq_flags_trim() must be called
> ahead.
>
> Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
> Cc: orika@mellanox.com
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 5:24 [dpdk-dev] [PATCH] net/mlx5: fix flow destruction Yongseok Koh
2018-11-15 8:50 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).