DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array
@ 2018-11-15 13:08 Shreyansh Jain
  2018-11-23 16:32 ` Jerin Jacob
  0 siblings, 1 reply; 4+ messages in thread
From: Shreyansh Jain @ 2018-11-15 13:08 UTC (permalink / raw)
  To: dev; +Cc: Shreyansh Jain

rte_rawdevs is expected to be deprecated in future releases. This is
not expected to be directly used, without API access that is, by any
external application or driver.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

---
 This is in sync with discussion in [1]
 [1] http://mails.dpdk.org/archives/dev/2018-October/114592.html
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 34b28234c..776b9b245 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -55,3 +55,8 @@ Deprecation Notices
   - ``rte_pdump_set_socket_dir`` will be removed;
   - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
   - The enum ``rte_pdump_socktype`` will be removed.
+
+* rawdev: ``rte_rawdevs`` is an array containing all registered raw devices.
+  Currently this is exposed from the library. Ideally, no application should
+  be directly using it. This is expected to be deprecated and made internal
+  in v19.02 or later.
-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array
  2018-11-15 13:08 [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array Shreyansh Jain
@ 2018-11-23 16:32 ` Jerin Jacob
  2018-11-24 17:33   ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob @ 2018-11-23 16:32 UTC (permalink / raw)
  To: Shreyansh Jain; +Cc: dev

-----Original Message-----
> Date: Thu, 15 Nov 2018 13:08:14 +0000
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> To: "dev@dpdk.org" <dev@dpdk.org>
> CC: Shreyansh Jain <shreyansh.jain@nxp.com>
> Subject: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed
>  array
> x-mailer: git-send-email 2.17.1
> 
> 
> rte_rawdevs is expected to be deprecated in future releases. This is
> not expected to be directly used, without API access that is, by any
> external application or driver.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>


Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> 
> ---
>  This is in sync with discussion in [1]
>  [1] http://mails.dpdk.org/archives/dev/2018-October/114592.html
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 34b28234c..776b9b245 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -55,3 +55,8 @@ Deprecation Notices
>    - ``rte_pdump_set_socket_dir`` will be removed;
>    - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
>    - The enum ``rte_pdump_socktype`` will be removed.
> +
> +* rawdev: ``rte_rawdevs`` is an array containing all registered raw devices.
> +  Currently this is exposed from the library. Ideally, no application should
> +  be directly using it. This is expected to be deprecated and made internal
> +  in v19.02 or later.
> --
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array
  2018-11-23 16:32 ` Jerin Jacob
@ 2018-11-24 17:33   ` Thomas Monjalon
  2018-11-26  8:35     ` Shreyansh Jain
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-11-24 17:33 UTC (permalink / raw)
  To: Shreyansh Jain; +Cc: dev, Jerin Jacob

23/11/2018 17:32, Jerin Jacob:
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> > 
> > rte_rawdevs is expected to be deprecated in future releases. This is
> > not expected to be directly used, without API access that is, by any
> > external application or driver.
> > 
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

There are not enoughs acks for this change.
Anyway, you should first make this array useless by removing any access
from rte_rawdev_pmd.h. Then you will be able to deprecate it from public API.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array
  2018-11-24 17:33   ` Thomas Monjalon
@ 2018-11-26  8:35     ` Shreyansh Jain
  0 siblings, 0 replies; 4+ messages in thread
From: Shreyansh Jain @ 2018-11-26  8:35 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Jerin Jacob

On Saturday 24 November 2018 11:03 PM, Thomas Monjalon wrote:
> 23/11/2018 17:32, Jerin Jacob:
>> From: Shreyansh Jain <shreyansh.jain@nxp.com>
>>>
>>> rte_rawdevs is expected to be deprecated in future releases. This is
>>> not expected to be directly used, without API access that is, by any
>>> external application or driver.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>
>> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> There are not enoughs acks for this change.
> Anyway, you should first make this array useless by removing any access
> from rte_rawdev_pmd.h. Then you will be able to deprecate it from public API.

Ok. I will send removals in this release (1902) and resend the deprecation.

Thanks Jerin for reading through and Ack.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-26  8:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 13:08 [dpdk-dev] [PATCH] doc: announce deprecation of rawdev exposed array Shreyansh Jain
2018-11-23 16:32 ` Jerin Jacob
2018-11-24 17:33   ` Thomas Monjalon
2018-11-26  8:35     ` Shreyansh Jain

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git