From: Tomasz Duszynski <tdu@semihalf.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Tomasz Duszynski <tdu@semihalf.com>,
Dmitri Epshtein <dima@marvell.com>,
Natalie Samsonov <nsamsono@marvell.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mvpp2: fix possible uninitialized variable access
Date: Thu, 15 Nov 2018 15:38:00 +0100 [thread overview]
Message-ID: <20181115143800.GA10746@sh> (raw)
In-Reply-To: <20181105152522.66712-1-ferruh.yigit@intel.com>
On Mon, Nov 05, 2018 at 03:25:22PM +0000, Ferruh Yigit wrote:
> Fixes: cdb53f8da628 ("net/mvpp2: support metering")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/mvpp2/mrvl_mtr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/mrvl_mtr.c
> index 9cd53bed5..9adcd9751 100644
> --- a/drivers/net/mvpp2/mrvl_mtr.c
> +++ b/drivers/net/mvpp2/mrvl_mtr.c
> @@ -422,7 +422,7 @@ mrvl_meter_profile_update(struct rte_eth_dev *dev, uint32_t mtr_id,
> struct mrvl_priv *priv = dev->data->dev_private;
> struct mrvl_mtr_profile *profile;
> struct mrvl_mtr *mtr;
> - int ret, enabled;
> + int ret, enabled = 0;
>
> if (!priv->ppio)
> return -rte_mtr_error_set(error, EPERM,
> --
> 2.17.2
>
Looks good.
Acked-by: Tomasz Duszynski <tdu@semihalf.com>
--
- Tomasz Duszyński
next prev parent reply other threads:[~2018-11-15 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 15:25 Ferruh Yigit
2018-11-15 14:38 ` Tomasz Duszynski [this message]
2018-11-16 10:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115143800.GA10746@sh \
--to=tdu@semihalf.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=ferruh.yigit@intel.com \
--cc=nsamsono@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).