DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done
@ 2018-11-20  1:39 Fiona Trahe
  2018-11-20  1:53 ` Stephen Hemminger
                   ` (2 more replies)
  0 siblings, 3 replies; 21+ messages in thread
From: Fiona Trahe @ 2018-11-20  1:39 UTC (permalink / raw)
  To: dev
  Cc: akhil.goyal, tomaszx.jozwiak, shally.verma, ashish.gupta,
	lee.daly, fiona.trahe

A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE
is added. A PMD which processes operations using a software
acceleration engine should set this if the bulk of the
processing is done during the dequeue. It should leave it
cleared if the bulk of the processing is done during the
enqueue (default).
An application may find this useful for tuning.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 lib/librte_compressdev/rte_compressdev.c | 2 ++
 lib/librte_compressdev/rte_compressdev.h | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib/librte_compressdev/rte_compressdev.c
index 10101eb..90d6862 100644
--- a/lib/librte_compressdev/rte_compressdev.c
+++ b/lib/librte_compressdev/rte_compressdev.c
@@ -66,6 +66,8 @@ rte_compressdev_get_feature_name(uint64_t flag)
 		return "CPU_AVX512";
 	case RTE_COMPDEV_FF_CPU_NEON:
 		return "CPU_NEON";
+	case RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE:
+		return "OP_DONE_IN_DEQ";
 	default:
 		return NULL;
 	}
diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compressdev/rte_compressdev.h
index 7b68170..0fc8ed1 100644
--- a/lib/librte_compressdev/rte_compressdev.h
+++ b/lib/librte_compressdev/rte_compressdev.h
@@ -73,6 +73,14 @@ rte_compressdev_capability_get(uint8_t dev_id,
 /**< Utilises CPU SIMD AVX512 instructions */
 #define	RTE_COMPDEV_FF_CPU_NEON			(1ULL << 5)
 /**< Utilises CPU NEON instructions */
+#define RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE	(1ULL << 6)
+/**< Only applicable when RTE_COMPDEV_FF_HW_ACCELERATED flag
+ * is not set. A PMD which processes operations using a software
+ * acceleration engine should set this if the bulk of the
+ * processing is done during the dequeue. It should leave it
+ * cleared if the processing is done during the enqueue (default).
+ * An application may find this useful for tuning.
+ */
 
 /**
  * Get the name of a compress device feature flag.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 21+ messages in thread
* [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done
@ 2018-12-18 18:41 Luse, Paul E
  0 siblings, 0 replies; 21+ messages in thread
From: Luse, Paul E @ 2018-12-18 18:41 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: dev, akhil.goyal, Jozwiak, TomaszX, shally.verma, ashish.gupta,
	Daly, Lee, Trahe, Fiona

Resend wrong subject

-----Original Message-----
From: Trahe, Fiona
Sent: Tuesday, December 18, 2018 7:43 AM
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>; shally.verma@caviumnetworks.com; ashish.gupta@caviumnetworks.com; Daly, Lee <lee.daly@intel.com>; Luse, Paul E <paul.e.luse@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

Hi Stephen

//snip//
> > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to 
> > > specify where processing is done
> > >
> > > On Tue, 20 Nov 2018 01:39:48 +0000 Fiona Trahe 
> > > <fiona.trahe@intel.com> wrote:
> > >
> > > > A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE
> > > > is added. A PMD which processes operations using a software 
> > > > acceleration engine should set this if the bulk of the 
> > > > processing is done during the dequeue. It should leave it 
> > > > cleared if the bulk of the processing is done during the enqueue 
> > > > (default).
> > > > An application may find this useful for tuning.
> > > >
> > > > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > >
> > > What application? or is this "if we build it they will come?"
> > [Fiona] Our storage team asked for this, so not quite.
> > Seems like it might by generically useful, so a bit of the latter 
> > too :) Would you prefer I removed that line?
> 
> Hopefully, there would be one or more open source projects using the API.
> I just did a survey of DPDK an 1/3 of it is never used by any open 
> source project.  Hate to see more dead code and special cases created.
> 
> At least, some example code in examples would help. Something like a 
> simple in memory compressed storage server using a network API 
> (SMB?/SSH?/FTP?)
[Fiona] There is no compressdev sample app yet. 
However I've double-checked with the SPDK team, they're currently integrating compressdev and intend to push a patch to SPDK - a storage open-source project - using this flag.

Acked-by: Paul Luse <paul.e.luse@intel.com>

^ permalink raw reply	[flat|nested] 21+ messages in thread
end of thread, other threads:[~2019-03-22 15:09 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20  1:39 [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Fiona Trahe
2018-11-20  1:53 ` Stephen Hemminger
2018-11-20 16:25   ` Trahe, Fiona
2018-11-20 18:07     ` Stephen Hemminger
2018-12-18 14:43       ` Trahe, Fiona
2018-12-19  5:47         ` Verma, Shally
2018-12-19 17:09           ` Trahe, Fiona
2019-01-10 18:46             ` De Lara Guarch, Pablo
2019-01-12  6:47               ` Verma, Shally
2019-01-16 11:21               ` Shally Verma
2019-01-16 11:36                 ` Trahe, Fiona
2019-01-16 12:09                   ` Shally Verma
2019-01-16 12:44                     ` Trahe, Fiona
2019-01-16 13:47                       ` Shally Verma
2018-11-20  5:17 ` Verma, Shally
2018-11-20 16:40   ` Trahe, Fiona
2019-01-17 17:36 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
2019-02-20 16:00   ` Shally Verma
2019-03-22 15:09     ` Akhil Goyal
2019-03-22 15:09       ` Akhil Goyal
2018-12-18 18:41 [dpdk-dev] [PATCH] " Luse, Paul E

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).