From: Qi Zhang <qi.z.zhang@intel.com>
To: bruce.richardson@intel.com, keith.wiles@intel.com
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, bernard.iremonger@intel.com,
Qi Zhang <qi.z.zhang@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap performance
Date: Tue, 20 Nov 2018 12:45:37 +0800 [thread overview]
Message-ID: <20181120044537.9495-1-qi.z.zhang@intel.com> (raw)
The patch optimizes the mac swap operation by taking advantage
of SSE instructions, it only impacts x86 platform.
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
app/test-pmd/macswap.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c
index a8384d5b8..0722782b0 100644
--- a/app/test-pmd/macswap.c
+++ b/app/test-pmd/macswap.c
@@ -78,7 +78,6 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
struct rte_port *txp;
struct rte_mbuf *mb;
struct ether_hdr *eth_hdr;
- struct ether_addr addr;
uint16_t nb_rx;
uint16_t nb_tx;
uint16_t i;
@@ -95,6 +94,15 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
start_tsc = rte_rdtsc();
#endif
+#ifdef RTE_ARCH_X86
+ __m128i addr;
+ __m128i shfl_msk = _mm_set_epi8(15, 14, 13, 12,
+ 5, 4, 3, 2,
+ 1, 0, 11, 10,
+ 9, 8, 7, 6);
+#else
+ struct ether_addr addr;
+#endif
/*
* Receive a burst of packets and forward them.
*/
@@ -123,9 +131,15 @@ pkt_burst_mac_swap(struct fwd_stream *fs)
eth_hdr = rte_pktmbuf_mtod(mb, struct ether_hdr *);
/* Swap dest and src mac addresses. */
+#ifdef RTE_ARCH_X86
+ addr = _mm_loadu_si128((__m128i *)eth_hdr);
+ addr = _mm_shuffle_epi8(addr, shfl_msk);
+ _mm_storeu_si128((__m128i *)eth_hdr, addr);
+#else
ether_addr_copy(ð_hdr->d_addr, &addr);
ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr);
ether_addr_copy(&addr, ð_hdr->s_addr);
+#endif
mb->ol_flags &= IND_ATTACHED_MBUF | EXT_ATTACHED_MBUF;
mb->ol_flags |= ol_flags;
--
2.13.6
next reply other threads:[~2018-11-20 4:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 4:45 Qi Zhang [this message]
2018-11-20 9:16 ` Ananyev, Konstantin
2018-11-20 14:48 ` Wiles, Keith
2018-11-20 16:58 ` Zhang, Qi Z
2018-11-20 17:26 ` Ananyev, Konstantin
2018-11-20 22:53 ` Ananyev, Konstantin
2018-11-21 21:24 ` Zhang, Qi Z
2018-11-23 22:43 ` Wiles, Keith
2018-11-23 22:43 ` Wiles, Keith
2018-11-24 16:24 ` Wiles, Keith
2018-11-27 1:06 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120044537.9495-1-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).