* [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message
@ 2018-11-20 21:13 Stephen Hemminger
2018-11-27 16:18 ` Matan Azrad
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2018-11-20 21:13 UTC (permalink / raw)
To: matan; +Cc: dev, Stephen Hemminger
If vdev_netvsc is run with debug logging enabled, then the
log output will fill with:
net_vdev_netvsc: interface lo is non-ethernet device
Remove the message since it is not useful.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/vdev_netvsc/vdev_netvsc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index 16303ef5ef9b..ba63fac2a598 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -191,11 +191,8 @@ vdev_netvsc_foreach_iface(int (*func)(const struct if_nameindex *iface,
req.ifr_name, rte_strerror(errno));
continue;
}
- if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER) {
- DRV_LOG(DEBUG, "interface %s is non-ethernet device",
- req.ifr_name);
+ if (req.ifr_hwaddr.sa_family != ARPHRD_ETHER)
continue;
- }
memcpy(eth_addr.addr_bytes, req.ifr_hwaddr.sa_data,
RTE_DIM(eth_addr.addr_bytes));
va_start(ap, is_netvsc);
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message
2018-11-20 21:13 [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message Stephen Hemminger
@ 2018-11-27 16:18 ` Matan Azrad
2018-11-27 16:26 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2018-11-27 16:18 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
From: Stephen Hemminger
> If vdev_netvsc is run with debug logging enabled, then the log output will fill
> with:
> net_vdev_netvsc: interface lo is non-ethernet device
>
> Remove the message since it is not useful.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Matan Azrad <matan@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message
2018-11-27 16:18 ` Matan Azrad
@ 2018-11-27 16:26 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-27 16:26 UTC (permalink / raw)
To: Matan Azrad, Stephen Hemminger; +Cc: dev
On 11/27/2018 4:18 PM, Matan Azrad wrote:
>
>
> From: Stephen Hemminger
>> If vdev_netvsc is run with debug logging enabled, then the log output will fill
>> with:
>> net_vdev_netvsc: interface lo is non-ethernet device
>>
>> Remove the message since it is not useful.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Matan Azrad <matan@mellanox.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-27 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 21:13 [dpdk-dev] [PATCH] net/vdev_netvsc: get rid of unnecessary debug log message Stephen Hemminger
2018-11-27 16:18 ` Matan Azrad
2018-11-27 16:26 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).