DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] config: enable more than 128 cores for Arm64 platform
Date: Wed, 21 Nov 2018 11:34:42 +0000	[thread overview]
Message-ID: <20181121113422.GA31379@jerin> (raw)
In-Reply-To: <1542799632-47517-1-git-send-email-joyce.kong@arm.com>

-----Original Message-----
> Date: Wed, 21 Nov 2018 19:27:12 +0800
> From: Joyce Kong <joyce.kong@arm.com>
> To: dev@dpdk.org
> CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
>  Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, stable@dpdk.org
> Subject: [PATCH v2] config: enable more than 128 cores for Arm64 platform
> X-Mailer: git-send-email 2.7.4
> 
> 
> When running dpdk applications on cores whose ids are bigger
> than original max_core setting, eal error as below:
> EAL: Detected 104 lcore(s)
> EAL: Detected 2 NUMA nodes
> EAL: invalid core list
> -l CORELIST core indexes between 0 and 128
> 
> The fix is to increase max_core to 256 on Arm64 platform.
> 
> Fixes: b3ce00e5 ("mk: introduce ARMv8 architecture")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  config/arm/meson.build                     | 2 +-
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index b755138..020df09 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -51,7 +51,7 @@ flags_cavium = [
>         ['RTE_MACHINE', '"thunderx"'],
>         ['RTE_CACHE_LINE_SIZE', 128],
>         ['RTE_MAX_NUMA_NODES', 2],
> -       ['RTE_MAX_LCORE', 96],
> +       ['RTE_MAX_LCORE', 256],

This change makes thunderx config to 256 cores not armv8. 
For generic config, it needs to be under "flags_generic"
not under "flags_cavium". Just like you did for updating
defconfig_arm64-armv8a-linuxapp-gcc config instead of
defconfig_arm64-thunderx-linuxapp-gcc

>         ['RTE_MAX_VFIO_GROUPS', 128],
>         ['RTE_USE_C11_MEM_MODEL', false]]
>  flags_dpaa = [
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 1842744..a6ed90c 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -6,3 +6,4 @@
> 
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
> +CONFIG_RTE_MAX_LCORE=256
> --
> 2.7.4
> 

  reply	other threads:[~2018-11-21 11:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 11:10 [dpdk-dev] [PATCH v1 0/2] change max core number to 256 " Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 1/2] config: enable more than 128 cores for Arm platform Joyce Kong
2018-11-21 11:10 ` [dpdk-dev] [PATCH v1 2/2] config: enable more than 128 cores for meson build Joyce Kong
2018-11-21 11:13 ` [dpdk-dev] [PATCH v1 0/2] change max core number to 256 for Arm64 platform Thomas Monjalon
2018-11-21 11:41   ` Joyce Kong (Arm Technology China)
2018-11-21 20:09     ` Stephen Hemminger
2018-11-21 11:27 ` [dpdk-dev] [PATCH v2] config: enable more than 128 cores " Joyce Kong
2018-11-21 11:34   ` Jerin Jacob [this message]
2018-11-22  7:01     ` Joyce Kong (Arm Technology China)
2018-11-22  7:01 ` [dpdk-dev] [PATCH v3] " Joyce Kong
2018-11-22  7:08   ` Jerin Jacob
2018-11-22  7:43     ` Joyce Kong (Arm Technology China)
2018-11-22  7:37   ` [dpdk-dev] [PATCH v4] " Joyce Kong
2018-11-22 11:04     ` Jerin Jacob
2018-11-23  0:49       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181121113422.GA31379@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=joyce.kong@arm.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).