From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 0A2FC5F29 for ; Wed, 21 Nov 2018 14:11:38 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id u6so5506203plm.8 for ; Wed, 21 Nov 2018 05:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xEn67mgS/MIWvXbazm3vLRaQwBghQjptMWkdzI+4FrU=; b=iwF0Fb0KsBwslwsguAqOEZ6Gc4Q80khwQkpkQRt0V+re+/W7hNTLFmAcjSL9q4ZWE9 k9N0uCoqr5MYT1bnEzREWcZldbEWl/8PCo4qql/CUsEo+sSlKAr8QF1b2aWjlccg0w8I 0hhBrPTZIr7z4jYUfuO0pOQgIu1eVraDYlQhnsQPzaLbpEvFP3gVElhLyT7icY4U380W RljZGv1Oucv2r9dcYBxtzz/aJDUx9ja6271OlvN7mbelsVbItqZ7qRp52a39Tvo917nG IeGdppYdBWwAkxLwHC+SuYRlWim6JmiNeNMGEHlZCZi0sMypxFSVlx5RDPRq/p5Ss2gh I0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xEn67mgS/MIWvXbazm3vLRaQwBghQjptMWkdzI+4FrU=; b=NSSVUy6QxOSI4OHmeSFeLnuTuMazXhobY2Hx9mXOdIm1hYmJQoPJhcuNjZ1f3M1+IB rJ9PuXZRB13kToeNoOQkWeSqOKSoGIl3rDkxuF4vud7tNr8Dz2ENThtRS6yC9uLW7WTA Ckr5C5XzCY0oaoR7XYPIrtd9x+c5zDH4DKTuE+m9GE5wintdYJHkTA6fo6Qm66BK3Ado zrGHH9NEZ/9ptwEQx/pfiKmZvV3iXNPEMwOwvfOffYKkWTVJ5KJACMsJgbj0P797yq49 GxomTyx0vKwvfwlt8LEpBE29hJtGqQmCsJhYAw7alfOpCnLva/gPhvgg2iwqDMCyEYeE fDlA== X-Gm-Message-State: AA+aEWam1qfcU0Ao6L/4AEYYLGjKJC3k/K2RsvnQbGsIK/+MVcMc9ca4 NG9B4ZpFSTONPcr6fSLNxGKcfyAhmKk= X-Google-Smtp-Source: AJdET5fvPC70jzAeC3UMhBUu1k6jGgxqD5oy2m+/qRFcvw+WIWNDGZwiDA7NiwOUhNWovIITUYajQA== X-Received: by 2002:a63:4e41:: with SMTP id o1mr6045035pgl.282.1542805897204; Wed, 21 Nov 2018 05:11:37 -0800 (PST) Received: from localhost.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id l72-v6sm54729132pfi.149.2018.11.21.05.11.35 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Nov 2018 05:11:36 -0800 (PST) From: wanlebing X-Google-Original-From: wanlebing To: dev@dpdk.org Cc: wanlebing , wanlebing Date: Wed, 21 Nov 2018 21:11:27 +0800 Message-Id: <20181121131127.28528-1-wanlebing@didichuxing.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) Subject: [dpdk-dev] [PATCH] ethdev: fix memory leak on removing eth rxtx callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 13:11:38 -0000 eth rxtx callback is dynamically allocated using rte_zmalloc() but not released. Fix it by calling rte_free() to free callback when removing rxtx callback. Signed-off-by: wanlebing Signed-off-by: wanlebing --- lib/librte_ethdev/rte_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 5f858174b..f00311047 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -3926,6 +3926,7 @@ rte_eth_remove_rx_callback(uint16_t port_id, uint16_t queue_id, if (cb == user_cb) { /* Remove the user cb from the callback list. */ *prev_cb = cb->next; + rte_free(cb); ret = 0; break; } @@ -3960,6 +3961,7 @@ rte_eth_remove_tx_callback(uint16_t port_id, uint16_t queue_id, if (cb == user_cb) { /* Remove the user cb from the callback list. */ *prev_cb = cb->next; + rte_free(cb); ret = 0; break; } -- 2.14.1