DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: update commands for pdump
@ 2018-11-22  2:51 Tiwei Bie
  2018-11-22 16:36 ` Ferruh Yigit
  2018-11-22 17:54 ` Mcnamara, John
  0 siblings, 2 replies; 4+ messages in thread
From: Tiwei Bie @ 2018-11-22  2:51 UTC (permalink / raw)
  To: dev; +Cc: reshma.pattan, john.mcnamara, marko.kovacevic, stable

The --server-socket-path and --client-socket-path options
have already been removed. So also remove them from the doc
to avoid confusion.

Fixes: 09f4aa2b955f ("app/pdump: remove unused socket path options")
Cc: stable@dpdk.org

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
 doc/guides/tools/pdump.rst | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst
index 5168c81ab..7c2b73e72 100644
--- a/doc/guides/tools/pdump.rst
+++ b/doc/guides/tools/pdump.rst
@@ -42,8 +42,6 @@ The tool has a number of command line options:
                                    [ring-size=<ring size>],
                                    [mbuf-size=<mbuf data size>],
                                    [total-num-mbufs=<number of mbufs>]'
-                          [--server-socket-path=<server socket dir>]
-                          [--client-socket-path=<client socket dir>]
 
 The ``--pdump`` command line option is mandatory and it takes various sub arguments which are described in
 below section.
@@ -56,14 +54,6 @@ below section.
 
       * Multiple instances of ``--pdump`` can be passed to capture packets on different port and queue combinations.
 
-The ``--server-socket-path`` command line option is optional. This represents the server socket directory.
-If no value is passed default values are used i.e. ``/var/run/.dpdk/`` for root users and ``~/.dpdk/``
-for non root users.
-
-The ``--client-socket-path`` command line option is optional. This represents the client socket directory.
-If no value is passed default values are used i.e. ``/var/run/.dpdk/`` for root users and ``~/.dpdk/``
-for non root users.
-
 
 The ``--pdump`` parameters
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
-- 
2.14.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: update commands for pdump
  2018-11-22  2:51 [dpdk-dev] [PATCH] doc: update commands for pdump Tiwei Bie
@ 2018-11-22 16:36 ` Ferruh Yigit
  2018-11-22 17:54 ` Mcnamara, John
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2018-11-22 16:36 UTC (permalink / raw)
  To: Tiwei Bie, dev; +Cc: reshma.pattan, john.mcnamara, marko.kovacevic, stable

On 11/22/2018 2:51 AM, Tiwei Bie wrote:
> The --server-socket-path and --client-socket-path options
> have already been removed. So also remove them from the doc
> to avoid confusion.
> 
> Fixes: 09f4aa2b955f ("app/pdump: remove unused socket path options")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: update commands for pdump
  2018-11-22  2:51 [dpdk-dev] [PATCH] doc: update commands for pdump Tiwei Bie
  2018-11-22 16:36 ` Ferruh Yigit
@ 2018-11-22 17:54 ` Mcnamara, John
  2018-11-25  9:57   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Mcnamara, John @ 2018-11-22 17:54 UTC (permalink / raw)
  To: Bie, Tiwei, dev; +Cc: Pattan, Reshma, Kovacevic, Marko, stable



> -----Original Message-----
> From: Bie, Tiwei
> Sent: Thursday, November 22, 2018 2:52 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] doc: update commands for pdump
> 
> The --server-socket-path and --client-socket-path options have already
> been removed. So also remove them from the doc to avoid confusion.


Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: update commands for pdump
  2018-11-22 17:54 ` Mcnamara, John
@ 2018-11-25  9:57   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-11-25  9:57 UTC (permalink / raw)
  To: Bie, Tiwei; +Cc: stable, Mcnamara, John, dev, Pattan, Reshma, Kovacevic, Marko

22/11/2018 18:54, Mcnamara, John:
> From: Bie, Tiwei
> > The --server-socket-path and --client-socket-path options have already
> > been removed. So also remove them from the doc to avoid confusion.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-25  9:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22  2:51 [dpdk-dev] [PATCH] doc: update commands for pdump Tiwei Bie
2018-11-22 16:36 ` Ferruh Yigit
2018-11-22 17:54 ` Mcnamara, John
2018-11-25  9:57   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).