From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 0F7A21B20A for ; Thu, 22 Nov 2018 10:04:54 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id c14so2799002wrr.0 for ; Thu, 22 Nov 2018 01:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yrkSu+4VkM0AchHUNLcBnrTqpHZN7RoKUFgvtSFb0hs=; b=pK7Y9K8/NrLhVmZfSRNB/rGl9ik8d/Crndt3y5Xhp5hpzUT4cp7DN+v3OymUdl7hXQ Y4CJu0sIcNOvI6oNzw1WFErb+LrzqwXltMrqxgtIH1/a8VV7DAZuDMDCnKCIFFTmhcuS O53CHuNnQHh37INkkCZd1nZZ3w3cCUb9mCEVolo/EKFjOE3e0ms/02InPkv1y37YNLPO pnsIQiOXcEvYpzyuE1YbAzmgC4sY9hCx1rdDjpunQRTAPC920cfVwJmDNuzxJrXzkpyW T9BtAeSGxTOPDA6K5FKzSuyoW5ZRc76wlYWGXsI+spSenBgOLXZo+l5MgUUs2uUnvCwR vP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yrkSu+4VkM0AchHUNLcBnrTqpHZN7RoKUFgvtSFb0hs=; b=jfOpfovOYV74Sx8hj3trqFXGpYAmWC5bEbdHnigpqvF9rAMRWSnWhjK64ZFdyPBvRM eC8qgDoFL1sTIVyeXKaauHSpOYbwmblROMTJG/TZE57MUH1JYSnQm0pWIqvztcaxfWDD rHKq/ZMWRUD3BJObGqYh/QFAqkR7BZaZtI5gX7lJ+wzEpLWMMrm5km8JI0pbIoVYVDAN 957/AEcWpBVS9bqmiWhvdWRfDc63O9LTo4vckovmOanASdKlUnlj1Y256tQI/xQAPZXp n8EmOKQt03iPd3vI7huhIG6ePnG9Ju/hicz4y+FxGQjqcwjM30tsu50/irQxi+ywms33 7w1Q== X-Gm-Message-State: AA+aEWawzzohmVKUdSlkO6a6RDMGyvL9OxaRMVS+aBifHBPZSjS/LJ4h wibFFEycgQjgS2wjN5nUqBkkWg== X-Google-Smtp-Source: AFSGD/WqaPyhsJfjMV00X7R06aTnNGggFHHRiyeTi7yDgRPZqx1UxeB6uGgmQVBk+Pjl5OUY7sLMzA== X-Received: by 2002:adf:8b8e:: with SMTP id o14-v6mr5050293wra.81.1542877493652; Thu, 22 Nov 2018 01:04:53 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r3-v6sm4259949wmd.25.2018.11.22.01.04.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Nov 2018 01:04:52 -0800 (PST) Date: Thu, 22 Nov 2018 10:04:33 +0100 From: Adrien Mazarguil To: Dekel Peled Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, dev@dpdk.org, orika@mellanox.com, shahafs@mellanox.com Message-ID: <20181122090433.GJ17131@6wind.com> References: <1542646490-37406-1-git-send-email-dekelp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542646490-37406-1-git-send-email-dekelp@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 09:04:54 -0000 On Mon, Nov 19, 2018 at 06:54:50PM +0200, Dekel Peled wrote: > Set MPLS label value in appropriate location at mplsoudp_encap_conf, > so it is correctly copied to rte_flow_item_mpls. > > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") > Cc: orika@mellanox.com > > Signed-off-by: Dekel Peled > --- > app/test-pmd/cmdline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 1275074..40e64cc 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -15804,10 +15804,10 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result, > struct cmd_set_mplsoudp_encap_result *res = parsed_result; > union { > uint32_t mplsoudp_label; > - uint8_t label[3]; > + uint8_t label[4]; > } id = { > .mplsoudp_label = > - rte_cpu_to_be_32(res->label) & RTE_BE32(0x00ffffff), > + rte_cpu_to_be_32(res->label<<4) & RTE_BE32(0x00ffffff), Just to be sure, since label is a 20-bit value, isn't the shift supposed to be 12 bits? In which case that mask is harmless but misleading. How about: .mplsoudp_label = rte_cpu_to_be32((res->label & 0xfffff) << 12); > }; > > if (strcmp(res->mplsoudp, "mplsoudp_encap") == 0) > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND