From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Dekel Peled <dekelp@mellanox.com>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation
Date: Thu, 22 Nov 2018 11:14:21 +0100 [thread overview]
Message-ID: <20181122101421.GK17131@6wind.com> (raw)
In-Reply-To: <VI1PR05MB42244FA615D64B67AE2CB0B1B6DB0@VI1PR05MB4224.eurprd05.prod.outlook.com>
On Thu, Nov 22, 2018 at 09:56:09AM +0000, Dekel Peled wrote:
> Thanks, PSB.
>
> > -----Original Message-----
> > From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Sent: Thursday, November 22, 2018 11:05 AM
> > To: Dekel Peled <dekelp@mellanox.com>
> > Cc: wenzhuo.lu@intel.com; jingjing.wu@intel.com;
> > bernard.iremonger@intel.com; dev@dpdk.org; Ori Kam
> > <orika@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation
> >
> > On Mon, Nov 19, 2018 at 06:54:50PM +0200, Dekel Peled wrote:
> > > Set MPLS label value in appropriate location at mplsoudp_encap_conf,
> > > so it is correctly copied to rte_flow_item_mpls.
> > >
> > > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation")
> > > Cc: orika@mellanox.com
> > >
> > > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > > ---
> > > app/test-pmd/cmdline.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > > 1275074..40e64cc 100644
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -15804,10 +15804,10 @@ static void
> > cmd_set_mplsoudp_encap_parsed(void *parsed_result,
> > > struct cmd_set_mplsoudp_encap_result *res = parsed_result;
> > > union {
> > > uint32_t mplsoudp_label;
> > > - uint8_t label[3];
> > > + uint8_t label[4];
> > > } id = {
> > > .mplsoudp_label =
> > > - rte_cpu_to_be_32(res->label) &
> > RTE_BE32(0x00ffffff),
> > > + rte_cpu_to_be_32(res->label<<4) &
> > RTE_BE32(0x00ffffff),
> >
> > Just to be sure, since label is a 20-bit value, isn't the shift supposed to be 12
> > bits? In which case that mask is harmless but misleading. How about:
> >
> > .mplsoudp_label = rte_cpu_to_be32((res->label & 0xfffff) << 12);
> >
>
> Label is 20-bits value in a 24-bits field, see struct rte_flow_item_mpls.
OK, I know, what I missed was the following line:
rte_memcpy(mplsoudp_encap_conf.label, &id.label[1], 3);
Just a suggestion then: using the same memcpy() offsets in both places for
clarity:
rte_be32_t label = rte_cpu_to_be32(res->label << 12);
memcpy(mplsodudp_encap_conf.label, &label, 3);
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-11-22 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 16:54 Dekel Peled
2018-11-20 8:23 ` Ori Kam
2018-11-21 15:19 ` Ferruh Yigit
2018-11-21 15:39 ` Ori Kam
2018-11-22 9:04 ` Adrien Mazarguil
2018-11-22 9:56 ` Dekel Peled
2018-11-22 10:14 ` Adrien Mazarguil [this message]
2018-11-22 16:18 ` Dekel Peled
2018-11-22 16:39 ` Ferruh Yigit
2018-12-04 13:51 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2018-12-04 21:23 ` Ori Kam
2018-12-06 8:17 ` Dekel Peled
2018-12-06 9:38 ` Ori Kam
2018-12-11 17:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122101421.GK17131@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).