From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce kvargs API change
Date: Fri, 23 Nov 2018 16:31:11 +0000 [thread overview]
Message-ID: <20181123163058.GA11828@jerin> (raw)
In-Reply-To: <ba382836-0647-2f1d-8693-9e346fcdd335@intel.com>
-----Original Message-----
> Date: Thu, 22 Nov 2018 17:08:56 +0000
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Olivier Matz <olivier.matz@6wind.com>, Thomas Monjalon
> <thomas@monjalon.net>
> CC: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: announce kvargs API change
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
> Thunderbird/60.3.1
>
>
> On 11/22/2018 1:22 PM, Olivier Matz wrote:
> > On Thu, Nov 22, 2018 at 11:32:23AM +0100, Thomas Monjalon wrote:
> >> After processing a kvlist in rte_kvargs_process(),
> >> it may be needed to loop again over kvlist in order to know
> >> whether the key is matched or not.
> >> In order to simplify implementation of kvargs checks,
> >> a new pointer parameter may be used to get the match count.
> >>
> >> The change of the function prototype would be as below:
> >>
> >> int
> >> rte_kvargs_process(const struct rte_kvargs *kvlist,
> >> const char *key_match,
> >> + int *match_count,
> >> arg_handler_t handler,
> >> void *opaque_arg)
> >>
> >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Maybe "unsigned int" instead of "int".
> >
> > Apart from this,
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
next prev parent reply other threads:[~2018-11-23 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 15:45 [dpdk-dev] [PATCH] " Thomas Monjalon
2018-11-22 10:32 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2018-11-22 13:22 ` Olivier Matz
2018-11-22 14:02 ` Thomas Monjalon
2018-11-22 17:08 ` Ferruh Yigit
2018-11-23 16:31 ` Jerin Jacob [this message]
2018-11-24 17:12 ` Thomas Monjalon
2018-11-23 13:17 ` [dpdk-dev] [PATCH] " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123163058.GA11828@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).