From: Jens Freimann <jfreimann@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix possible null pointer dereferencing
Date: Tue, 27 Nov 2018 11:30:28 +0100 [thread overview]
Message-ID: <20181127103028.tsbjraer4oz3wiss@jenstp.localdomain> (raw)
In-Reply-To: <20181127095451.18217-1-maxime.coquelin@redhat.com>
On Tue, Nov 27, 2018 at 10:54:51AM +0100, Maxime Coquelin wrote:
>If mmap() call fails in vhost_user_set_mem_table, dev->mem
>is set to NULL. If later, qva_to_vva() is called, a segfault
>occurs.
>
>Fixes: 8f972312b8f4 ("vhost: support vhost-user")
>Cc: stable@dpdk.org
>
>Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
> lib/librte_vhost/vhost_user.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Jumping to an out label would have worked as well, but it doesn't
really matter.
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2018-11-27 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 9:54 Maxime Coquelin
2018-11-27 10:30 ` Jens Freimann [this message]
2018-12-11 18:30 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127103028.tsbjraer4oz3wiss@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).