From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com
 [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 39F6A262E
 for <dev@dpdk.org>; Thu, 29 Nov 2018 19:15:16 +0100 (CET)
Received: by mail-pf1-f169.google.com with SMTP id u6so1406260pfh.11
 for <dev@dpdk.org>; Thu, 29 Nov 2018 10:15:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=3BnxrgzfKp99qQn20F/d/LYVga3UABRQ+71qCu1ApCU=;
 b=SZRsDXAKdqFlDD5ox+mpt87TpyUxiKmGsE8c4UwHpPxVwQwxAAVJWE7z11btNe2prg
 P9FKiz8YbDIicJW89s2BsTobNUo+tAzULjmz43764WvZHQuBhTam3VnTpoHKOF6RC27X
 JmA04XM61WtkZHZeLaFfBnO3/G9XUgYUbDTokeNft36hTqcXsvNteiXEtrjONuXiDccF
 bSMPtJLb+0COCjKpZL+XmFBQZUBYrpHtLiMQ3JM2zSRNcUXAHEXa+02rJo/GCHWQr5yp
 B8qnbbvlUa0eVT6eQzXeu22xuh3R+hAFOVuamGgRz6X0HH2+G9o+wZygGjGAvBsTsehT
 SFYQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=3BnxrgzfKp99qQn20F/d/LYVga3UABRQ+71qCu1ApCU=;
 b=llTyf432GlSKST2LHkC35zq/0TjfBGfybFSrN7zmx+C2gcd1/+mrv/EilnMakeY6mb
 jA/NouiEl3evCH/LKyPtDTpLhVk6aeeIZwS7j90cqQMaWB/oZz6rPyo+bxbiNlEIB8Dt
 ItuGdq8fvEpelav36tQAk01p0c+iaFziEJhhIKlNMQU2aa+Lj0VSSG4CGPwWQL+1xHm0
 0MJVyTB6UksOCCPXf1G7Mvu2AR5jZX3eMo8GYlZ/erXlDFgpkHUwNjEaD8wmhp04mZ23
 RgCf7Aiun3hPiVRjZEfD+0kZu50z4lzRNCc2UHd5wuo7qXP04BLyIDjlWOlo12fBfw6/
 OaCw==
X-Gm-Message-State: AA+aEWY2tbtm9x47krzTYgnwwSrw+sOTBQ1MK3Cvo4D8YRSk1Gq4ZHhn
 oqu/xXAVN9mi8lvAxQKE0JEf2Q==
X-Google-Smtp-Source: AFSGD/WH/7NNGFcTo20VVE81YPhCREgMfqwDKEMTDkz/E/WxJ7aHGQ0icyfhvQIVEXszERxm178AIQ==
X-Received: by 2002:a63:1c09:: with SMTP id c9mr2085548pgc.200.1543515315139; 
 Thu, 29 Nov 2018 10:15:15 -0800 (PST)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id 78sm3476006pft.184.2018.11.29.10.15.14
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 29 Nov 2018 10:15:14 -0800 (PST)
Date: Thu, 29 Nov 2018 10:15:06 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org
Message-ID: <20181129101506.32c9de3c@xeon-e3>
In-Reply-To: <20181129050504.26996-1-pallavi.kadam@intel.com>
References: <20181129050504.26996-1-pallavi.kadam@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] helloworld: Windows DPDK sample application
 is compiled and built using eal and kvargs libraries in order to add
 windows support in the mainline repository.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2018 18:15:16 -0000

On Wed, 28 Nov 2018 21:05:04 -0800
Pallavi Kadam <pallavi.kadam@intel.com> wrote:

> +// If we define WIN32_LEAN_AND_MEAN, winsock isn't included by default. We can then include it in specific header files as we need later.
> +#define WIN32_LEAN_AND_MEAN

All this is Windows code, it would be best if the code style of the new code
matches the rest of the DPDK. The DPDK follows subset of Linux kernel style
standard. In that standard C++ style comments are not used.