From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com
 [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 69EB61B4DC
 for <dev@dpdk.org>; Thu, 29 Nov 2018 22:22:01 +0100 (CET)
Received: by mail-pl1-f193.google.com with SMTP id b5so1670579plr.4
 for <dev@dpdk.org>; Thu, 29 Nov 2018 13:22:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=TG3MZNBmDOR2UJ2jTt1nfmc3sJ8EsfpCEsbtaEnc56M=;
 b=wnYTVE8Z4QQdGiP+jqN8OcBbPl2VsVudGUKnGGiwzASSMAmgAXom17rs3bZcCFmDXv
 P9DQ+nqFXfoCQA2/n/of9oq+JmQ+jdHARfRHxr66k8rNucQvS+XeUSfS+WdAGtPF0Zwd
 Q69M/jsWd0N21b/MnLg1Qkr0u8S2tCxG/OsExSNUANuYG5vpw5pAmWGsP4wpU+h9G0Hi
 XHe3bMqXGuJQla/Q8tSmGfdaqpxs1O/2n9y4IeEKHBqbVcz2TR25S7OrXZD+xc0gm0zp
 s6+yPZt2r9Gb2B4NVQXpSboAM1Ofhxe45Hs2hLPSdrcl9YnC2ebaGMNvL9rBqNL7jSAG
 t09g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TG3MZNBmDOR2UJ2jTt1nfmc3sJ8EsfpCEsbtaEnc56M=;
 b=N9x8ABx4ONPSQV5tvfA1MEVur/k2R3M8n1g/IUQPq1ZbRfWblWvBphsJjp2n6SidOa
 LvpV63CjQx++g5Q4iR5dG0uEqWr5HYkg06jVjTilGN7ewvoqYHexT7LgktGSDQBuQE2Z
 poQqirygpLqbclZBW2ZSfJJLGyqokhYkvIAP/v5iTosMbvSRpZo6NvBLYLHLl7qniy+c
 r3Qod0L151NGJsFAfxPfHPL7mHSMl8n4pQimtPfQxEaUmywFU/ZnqujszdcMcZbwne4J
 5k2oXHfBAQPH6xGpovYyv4XZrNosR2brROL+P1m7K5mGlLybfc8l9bNsHfP2pteIgFh5
 knRg==
X-Gm-Message-State: AA+aEWYnHe5KNtIPf1sNgVC1TGL6HY0u4U58yP/54MJFQPERvjatOZ5X
 0TF+vvFJc24WZR+bgYn9dR/8lQ==
X-Google-Smtp-Source: AFSGD/WS+lp3PxNC52m+CsTubGczYl9pLI2GLWxswr2dF7juRmZzZjHhcB1khaEi0rk/tppPSkGSxg==
X-Received: by 2002:a17:902:ac8f:: with SMTP id
 h15mr2930597plr.245.1543526520320; 
 Thu, 29 Nov 2018 13:22:00 -0800 (PST)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id i4sm6536942pfj.82.2018.11.29.13.21.59
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 29 Nov 2018 13:21:59 -0800 (PST)
Date: Thu, 29 Nov 2018 13:21:52 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: "Jacob,  Jerin" <Jerin.JacobKollanukkaran@cavium.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Bhagavatula, Pavan" <Pavan.Bhagavatula@cavium.com>
Message-ID: <20181129132152.754ce410@xeon-e3>
In-Reply-To: <20181129083138.23029-1-pbhagavatula@caviumnetworks.com>
References: <20181129083138.23029-1-pbhagavatula@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2018 21:22:02 -0000

On Thu, 29 Nov 2018 08:32:03 +0000
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> wrote:

> When estimating tsc frequency using sleep/gettime round it up to the
> nearest multiple of 10Mhz for more accuracy.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Rounding reduces accuracy.

Why is this code being used?  Shouldn't get_tsc_freq_arch return a
correct value?

How well does the rdmsr() logic work in VM?
It looks like Hyper-V has special MSR's for TSC frequency determination.