DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dharmik Thakkar <dharmik.thakkar@arm.com>
To: byron.marohn@intel.com, pablo.de.lara.guarch@intel.com,
	bruce.richardson@intel.com, rsanford@akamai.com
Cc: dev@dpdk.org, Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-dev] [PATCH 2/3] test/efd: enable unit test compilation always
Date: Thu, 29 Nov 2018 14:31:11 -0600	[thread overview]
Message-ID: <20181129203112.12222-3-dharmik.thakkar@arm.com> (raw)
In-Reply-To: <20181129203112.12222-1-dharmik.thakkar@arm.com>

This patch enables compilation of print_key_info() always using
log-level based approach instead of a macro. Need to set efd log type
to debug to print debug information, using the following eal parameter:
--log-type=efd,8

Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
---
 test/test/test_efd.c | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/test/test/test_efd.c b/test/test/test_efd.c
index ced091aab63d..3b6f9db13565 100644
--- a/test/test/test_efd.c
+++ b/test/test/test_efd.c
@@ -34,28 +34,20 @@ struct flow_key {
 /*
  * Print out result of unit test efd operation.
  */
-#if defined(UNIT_TEST_EFD_VERBOSE)
-
 static void print_key_info(const char *msg, const struct flow_key *key,
 		efd_value_t val)
 {
-	const uint8_t *p = (const uint8_t *) key;
-	unsigned int i;
+	if (rte_log_get_level(RTE_LOGTYPE_EFD) == RTE_LOG_DEBUG) {
+		const uint8_t *p = (const uint8_t *) key;
+		unsigned int i;
 
-	printf("%s key:0x", msg);
-	for (i = 0; i < sizeof(struct flow_key); i++)
-		printf("%02X", p[i]);
-
-	printf(" @ val %d\n", val);
-}
-#else
+		printf("%s key:0x", msg);
+		for (i = 0; i < sizeof(struct flow_key); i++)
+			printf("%02X", p[i]);
 
-static void print_key_info(__attribute__((unused)) const char *msg,
-		__attribute__((unused)) const struct flow_key *key,
-		__attribute__((unused)) efd_value_t val)
-{
+		printf(" @ val %d\n", val);
+	}
 }
-#endif
 
 /* Keys used by unit test functions */
 static struct flow_key keys[5] = {
-- 
2.17.1

  parent reply	other threads:[~2018-11-29 20:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 20:31 [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2018-11-29 20:31 ` Dharmik Thakkar [this message]
2018-11-29 20:31 ` [dpdk-dev] [PATCH 3/3] test/timer: enable unit test compilation always Dharmik Thakkar
2019-01-11 16:30 ` [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level Ferruh Yigit
2019-02-20 22:47 ` [dpdk-dev] [PATCH v2 " Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 3/3] test/timer: " Dharmik Thakkar
2019-02-20 23:00   ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 3/3] test/timer: " Dharmik Thakkar
2019-02-20 23:08     ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Stephen Hemminger
2019-02-26 23:05       ` Dharmik Thakkar
2019-02-26 23:02     ` [dpdk-dev] [PATCH v4 " Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 3/3] test/timer: " Dharmik Thakkar
2019-03-28 18:26       ` [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level Thomas Monjalon
2019-03-28 18:26         ` Thomas Monjalon
2019-03-28 18:35         ` Thomas Monjalon
2019-03-28 18:35           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129203112.12222-3-dharmik.thakkar@arm.com \
    --to=dharmik.thakkar@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=rsanford@akamai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).