From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 00ED21B4F7 for ; Thu, 29 Nov 2018 21:32:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4058AEBD; Thu, 29 Nov 2018 12:32:28 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.12.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DFFEB3F5A0; Thu, 29 Nov 2018 12:32:27 -0800 (PST) From: Dharmik Thakkar To: byron.marohn@intel.com, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com, rsanford@akamai.com Cc: dev@dpdk.org, Dharmik Thakkar Date: Thu, 29 Nov 2018 14:31:11 -0600 Message-Id: <20181129203112.12222-3-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129203112.12222-1-dharmik.thakkar@arm.com> References: <20181129203112.12222-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH 2/3] test/efd: enable unit test compilation always X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 20:32:29 -0000 This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-type=efd,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- test/test/test_efd.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/test/test/test_efd.c b/test/test/test_efd.c index ced091aab63d..3b6f9db13565 100644 --- a/test/test/test_efd.c +++ b/test/test/test_efd.c @@ -34,28 +34,20 @@ struct flow_key { /* * Print out result of unit test efd operation. */ -#if defined(UNIT_TEST_EFD_VERBOSE) - static void print_key_info(const char *msg, const struct flow_key *key, efd_value_t val) { - const uint8_t *p = (const uint8_t *) key; - unsigned int i; + if (rte_log_get_level(RTE_LOGTYPE_EFD) == RTE_LOG_DEBUG) { + const uint8_t *p = (const uint8_t *) key; + unsigned int i; - printf("%s key:0x", msg); - for (i = 0; i < sizeof(struct flow_key); i++) - printf("%02X", p[i]); - - printf(" @ val %d\n", val); -} -#else + printf("%s key:0x", msg); + for (i = 0; i < sizeof(struct flow_key); i++) + printf("%02X", p[i]); -static void print_key_info(__attribute__((unused)) const char *msg, - __attribute__((unused)) const struct flow_key *key, - __attribute__((unused)) efd_value_t val) -{ + printf(" @ val %d\n", val); + } } -#endif /* Keys used by unit test functions */ static struct flow_key keys[5] = { -- 2.17.1