From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 802D41B525
 for <dev@dpdk.org>; Fri, 30 Nov 2018 16:28:49 +0100 (CET)
Received: from cpe-2606-a000-111b-453b-47b2-cd7-599-8cfa.dyn6.twc.com
 ([2606:a000:111b:453b:47b2:cd7:599:8cfa] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1gSUpm-0003ao-C4; Thu, 29 Nov 2018 17:30:59 -0500
Date: Fri, 30 Nov 2018 10:28:17 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, echaudro@redhat.com
Message-ID: <20181130152817.GI24285@hmswarspite.think-freely.org>
References: <1543400933-1723-1-git-send-email-david.marchand@redhat.com>
 <1543581122-22501-1-git-send-email-david.marchand@redhat.com>
 <1543581122-22501-2-git-send-email-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1543581122-22501-2-git-send-email-david.marchand@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Score: 0.3 (/)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: drop '+' from the section
	name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 15:28:49 -0000

On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote:
> The incriminated commit did relax the condition to catch all sections
> but dropped the + removal which can triggers false detection of the
> special EXPERIMENTAL section when adding symbols and the section in the
> same patch.
> 
> Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/check-symbol-change.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 4b8d9f3..020da7e 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -31,6 +31,7 @@ build_map_changes()
>  		# Triggering this rule sets in_sec to 1, which actives the
>  		# symbol rule below
>  		/^.*{/ {
> +			gsub("+", "");
>  			if (in_map == 1) {
>  				sec=$(NF-1); in_sec=1;
>  			}
> -- 
> 1.8.3.1
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Thanks!
Neil