From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 014901B105; Wed, 5 Dec 2018 13:24:07 +0100 (CET) Received: from cpe-2606-a000-111b-405a-a193-cb97-58ba-1c15.dyn6.twc.com ([2606:a000:111b:405a:a193:cb97:58ba:1c15] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1gUGKj-000692-Dk; Tue, 04 Dec 2018 14:26:19 -0500 Date: Wed, 5 Dec 2018 07:23:29 -0500 From: Neil Horman To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, tredaelli@redhat.com, ferruh.yigit@intel.com, amr.mokhtar@intel.com Message-ID: <20181205122329.GB6752@hmswarspite.think-freely.org> References: <1543957065-20990-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1543957065-20990-1-git-send-email-david.marchand@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: 0.3 (/) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH] bbdev: add missing experimental tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 12:24:08 -0000 On Tue, Dec 04, 2018 at 09:57:45PM +0100, David Marchand wrote: > Those two symbols are missing the experimental tag in the library > header. > Because of this, a user can try to call this symbol without being aware > this is an experimental api (neither compilation nor link warning). > > Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") > Signed-off-by: David Marchand > --- > lib/librte_bbdev/rte_bbdev_op.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h > index 83f62c2..c9200b5 100644 > --- a/lib/librte_bbdev/rte_bbdev_op.h > +++ b/lib/librte_bbdev/rte_bbdev_op.h > @@ -459,7 +459,7 @@ struct rte_bbdev_op_pool_private { > * Operation type as string or NULL if op_type is invalid > * > */ > -const char* > +__rte_experimental const char * > rte_bbdev_op_type_str(enum rte_bbdev_op_type op_type); > > /** > @@ -482,7 +482,7 @@ struct rte_bbdev_op_pool_private { > * - Pointer to a mempool on success, > * - NULL pointer on failure. > */ > -struct rte_mempool * > +__rte_experimental struct rte_mempool * > rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type, > unsigned int num_elements, unsigned int cache_size, > int socket_id); > -- > 1.8.3.1 > > Acked-by: Neil Horman