From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id EA33969D4 for ; Wed, 5 Dec 2018 23:52:57 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id z11so9704199pgu.0 for ; Wed, 05 Dec 2018 14:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AKEyGbPL6OBxn+UVkhc7LZObPKFmDXwjrcYhHIuWFvM=; b=nNvLHQVYAxcBFtXe9xvUpDvUcHqKkIs1lqiJrpXGSY4Vg/72qnU/FyLb46cFWN2rUL 8I1EC3eOiPEZQQJYDKjmHkISyyE5j/nYQaBF+DnZFo8bvMoZHliqXO7aJB9YWeaNx4Gk YIp06WZnKCFfQURK3kgT7kJmoZ2KoOZzKtQNK5Qkv40Bo0zCl+513bYljEQBMgQWmgl/ /hbBRGUKlqAgeyW9E7sP/2hUH8zuTMjSRojhJ+JSkyqQ4hMcJCLHHmJjf7gy8e6R+QEw Yx5CTDGUdKNcH3eDgf0a5a2zoVuBJMOIZhSsUr765Eg4S/Gj36yw6n0bcOZB4/dssoA8 s7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AKEyGbPL6OBxn+UVkhc7LZObPKFmDXwjrcYhHIuWFvM=; b=IVUNY6yvZLTM0HAw5r5ZAxRxc6wh2I5CQle6+/nms9zCQJCD+kyEbDZslVW97aRvSW dNzHW6AxtOjWyr+eaw5VexklvLw59XJQiNcRu6AaCb1pM1GpEXwoOEAe/q+ROWgoyOr+ 1L1qAL8w30KIjLka9/G5I4aVYh3UufMmYtEKP69N8K3JzPMAiGCmk/8Fy7GfMqZe9pJo JzgEsFl5hbwd+KmZZw3YsUbgNgLCQnYp2tSUqT+5BmjlzpfrWj+mzFdAiwdw/gozDARq kwE1pPmqBHxUjWkVBjt6jON+XrX/S6e9/zPr6TbpLpHg0uN/RI54RgDbB6Qa1YHcrAed Xk0w== X-Gm-Message-State: AA+aEWaE4qMruB8da293AUDBF/KPG5DZmA5jOiHUya7JJCMQEH/zFGR5 CYqhENUSV3ogXioQkAsS4h6V4w== X-Google-Smtp-Source: AFSGD/UXc9Ejzl9UZRceXZbGjPn6C8Iom6y6UIQ4Myxjp4qsPL+nXvdM/orMb/VrJ6vvEYv/OOqLpg== X-Received: by 2002:a62:ca05:: with SMTP id n5mr26215413pfg.154.1544050376799; Wed, 05 Dec 2018 14:52:56 -0800 (PST) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k137sm47464139pfd.56.2018.12.05.14.52.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Dec 2018 14:52:56 -0800 (PST) Date: Wed, 5 Dec 2018 14:52:54 -0800 From: Stephen Hemminger To: Maxime Coquelin Cc: Jens Freimann , dev@dpdk.org, tiwei.bie@intel.com, Gavin.Hu@arm.com Message-ID: <20181205145254.1eec5bae@xeon-e3> In-Reply-To: <21e02d5f-6f57-3333-3e82-69ab1ea64735@redhat.com> References: <20181203141515.28368-1-jfreimann@redhat.com> <20181203141515.28368-7-jfreimann@redhat.com> <21e02d5f-6f57-3333-3e82-69ab1ea64735@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 6/9] net/virtio: implement receive path for packed queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 22:52:58 -0000 On Wed, 5 Dec 2018 12:28:27 +0100 Maxime Coquelin wrote: > > +static uint16_t > > In think it should be inlined. > > > +virtqueue_dequeue_burst_rx_packed(struct virtqueue *vq, > > + struct rte_mbuf **rx_pkts, > > + uint32_t *len, > > + uint16_t num) Compiler will inline it anyway, and ignore inline directive if it is too big. Bottom line is for static functions there is no need of inline directive.