DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: mgamal@redhat.com, Stephen Hemminger <stephen@networkplumber.org>,
	Stephen Hemminger <sthemmin@microsoft.com>
Subject: [dpdk-dev] [PATCH v2 3/4] net/netvsc: disable multi-queue on older servers
Date: Wed,  5 Dec 2018 14:11:58 -0800	[thread overview]
Message-ID: <20181205221159.6336-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20181205221159.6336-1-stephen@networkplumber.org>

NDIS multi-queue support is only in WS2012 or later. Check the NDIS
version to limit to single queue on older versions. Similar code
exists in Linux driver.

Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/netvsc/hn_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index b330bf3d7255..1256fa399b16 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -732,6 +732,7 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)
 	hv->chim_res  = &vmbus->resource[HV_SEND_BUF_MAP];
 	hv->port_id = eth_dev->data->port_id;
 	hv->latency = HN_CHAN_LATENCY_NS;
+	hv->max_queues = 1;
 
 	err = hn_parse_args(eth_dev);
 	if (err)
@@ -770,6 +771,10 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)
 	if (err)
 		goto failed;
 
+	/* Multi queue requires later versions of windows server */
+	if (hv->nvs_ver < NVS_VERSION_5)
+		return 0;
+
 	max_chan = rte_vmbus_max_channels(vmbus);
 	PMD_INIT_LOG(DEBUG, "VMBus max channels %d", max_chan);
 	if (max_chan <= 0)
-- 
2.19.2

  parent reply	other threads:[~2018-12-05 22:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 11:04 [dpdk-dev] Problems running netvsc multiq Mohammed Gamal
2018-11-30 18:27 ` Stephen Hemminger
2018-11-30 19:06   ` Mohammed Gamal
2018-12-04 16:48     ` Stephen Hemminger
2018-12-04 16:56       ` Mohammed Gamal
2018-12-05 22:12         ` Stephen Hemminger
2018-12-05 22:32         ` Stephen Hemminger
2018-12-07 11:15           ` Mohammed Gamal
2018-12-07 17:31             ` Stephen Hemminger
2018-12-07 19:18             ` Stephen Hemminger
2018-12-08  8:10               ` Mohammed Gamal
2018-11-30 20:24 ` [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation Stephen Hemminger
2018-12-03  6:02   ` Mohammed Gamal
2018-12-03 16:48     ` Stephen Hemminger
2018-12-04 11:59       ` Mohammed Gamal
2018-12-05 22:11 ` [dpdk-dev] [PATCH v2 1/4] " Stephen Hemminger
2018-12-05 22:11   ` [dpdk-dev] [PATCH v2 2/4] net/netvsc: enable SR-IOV Stephen Hemminger
2018-12-05 22:11   ` Stephen Hemminger [this message]
2018-12-05 22:11   ` [dpdk-dev] [PATCH v2 4/4] bus/vmbus: debug subchannel setup Stephen Hemminger
2018-12-19  2:02   ` [dpdk-dev] [PATCH v2 1/4] bus/vmbus: fix race in sub channel creation Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205221159.6336-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=mgamal@redhat.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).